Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support hard links #763
referenced this pull request
Feb 1, 2017
Click on the red
The tests for Travis fail at the moment because the infrastructure for running tests on Darwin/OS X is broken: https://www.traviscistatus.com/incidents/k79mjcv403c4
Let's just wait a bit.
First, find out which commit(s) touch the files in the vendor directory (this assumes you are in the branch
Start an interactive rebase:
This opens an editor with a few lines at the top, one for each commit. Replace the word
It then looks like this:
Then discard the previous commit (so we can create a new one):
Discard all changes to files in the
Then add the files and make a commit as usual. This time, please adhere to the commit message format (short summary in first line, then an empty line, then more explanations):
Finish the rebase:
Then push the changes to github, overriding the old ones (hence the
That should do it :)
I believe that by default a backup application should capture and restore as much details as possible.
P.S. I'm glad that hardlinks and xattrs finally get support in Restic, without this I couldn't consider it a viable solution for my backup needs.
Ok, I think this is good so far. Thanks for your comments, I agree that restoring hardlinks should be the default. We can add an option when users request that.
So from my point of view the only thing missing is an integration test which archives hardlinked files, restores them again and verifies that the restored files are indeed hard links.
@@ Coverage Diff @@ ## master #763 +/- ## ========================================= - Coverage 54.28% 54.18% -0.1% ========================================= Files 95 96 +1 Lines 7277 7343 +66 ========================================= + Hits 3950 3979 +29 - Misses 2750 2783 +33 - Partials 577 581 +4
Thanks for asking, I didn't find the time yet to review the latest commits you pushed. I'll add a comment when something needs to be changed. Once your code is merged, I'll close this PR.
In order to cleanup the commit history, I will squash all your commits into one, and remove the changes
Did you find the file
Most integration tests can be run locally by running