restify-clients@1.3.2 breaks build 🚨 #59
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
restify-clients just published its new version 1.3.2.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As restify-clients is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 69 commits .
aa25055ignore the yarn lock file, if using yarn33fae2b1.3.27b774d0update node-uuid to get security fix43bf812ensure at least the min bunyan that works with node v48936ddebump to latest assert-plus, switch to assert.finite variants to keep same behaviour (disallowing Infinity)e1ff11aswitch back to restify-errors@3 to avoid backward incompatible change (#83)eed7990'make versioncheck' requires json from node_modulesd691925Update the changelog and 'make cutarelease' style31fb787fix bunyan.serializers export (that wasn't correctly done in #65) (#80)3bc24fechore(package): update restify-errors to version 4.2.3 (#42)16220f8chore(package): update eslint to version 3.1.0 (#71)b84820eprep for future dev7fb21ffprepare for 1.3.0 releasec7775b3add 'make cutarelease'e0fe472node 6.x breakage in "restify-client tests GH-115 GET path with spaces" test caseThere are 69 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade