Skip to content

Use default message for custom constructors #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonutEspresso merged 1 commit into from
Jul 30, 2017
Merged

Use default message for custom constructors #73

DonutEspresso merged 1 commit into from
Jul 30, 2017

Conversation

@ltvolks
Copy link
Contributor

@ltvolks ltvolks commented Jul 22, 2017

Fixes #37

@coveralls
Copy link

coveralls commented Jul 22, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.174% when pulling fbd8b5d on ltvolks:custom-error-default-message into a759b94 on restify:master.

@DonutEspresso
Copy link
Member

DonutEspresso commented Jul 27, 2017

Thank you @ltvolks, this looks great - highly appreciate the tests! @retrohacker @yunong any concerns on your end?

@DonutEspresso DonutEspresso merged commit bab0391 into restify:master Jul 30, 2017
@ltvolks ltvolks deleted the custom-error-default-message branch July 30, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retrohacker retrohacker Awaiting requested review from retrohacker

1 more reviewer

@yunong yunong yunong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ltvolks @coveralls @DonutEspresso @yunong