Skip to content

Conversation

@ltvolks
Copy link
Contributor

@ltvolks ltvolks commented Aug 1, 2017

Fixes #74

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 98.182% when pulling ca94a0c on ltvolks:tostring-repr into bab0391 on restify:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 98.182% when pulling ca94a0c on ltvolks:tostring-repr into bab0391 on restify:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 98.182% when pulling ca94a0c on ltvolks:tostring-repr into bab0391 on restify:master.

@DonutEspresso
Copy link
Member

Thanks @ltvolks! Can I just confirm that the problem is this:

Input:

const err = require('restify-errors');
err.makeConstructor('FooBarError');

var e = new err.FooBarError('boom');
console.warn(JSON.stringify(e));
console.warn(e.toString());

Output:

{"code":"FooBar","message":"boom"}
ErrCtor: boom

@DonutEspresso
Copy link
Member

Oops, somehow I missed #74. Thanks for the detailed breakdown and context, really appreciate it! @yunong @retrohacker, this LGTM, any concerns?

Copy link

@retrohacker retrohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@retrohacker retrohacker merged commit 9073a00 into restify:master Aug 11, 2017
@retrohacker
Copy link

Released as 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants