Skip to content

Add custom Content-Range unit names. #618

Closed
wants to merge 1 commit into from

3 participants

@rmetzger

This pull request contains some code to allow the user to set a custom Content-Range name.
Typically, the HTTP/1.1 protocol expects the "bytes" keyword in a Content-Range, e.g.
Content-Range: bytes 0-32/128

Some Web-Frameworks like Dojo expect another Range-Unit. It is specified by the HTTP protocol to use custom units for Content-Ranges: http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.12

The documentation of Dojo says: http://dojotoolkit.org/reference-guide/1.7/dojox/data/JsonRestStore.html

"The server should respond with a Content-Range header to indicate how many items are being returned and how many total items exist:
Content-Range: items 0-24/66"

@jlouvel
Restlet member
jlouvel commented Jul 11, 2012

Looks good! Here are some comments:

  • could you make sure that the header reader/parser also takes units into account?
  • a unit test verifying the header formating then parsing would be nice
  • we might want to squeeze this into the upcoming 2.1 RC7 release
  • could you sign a JCA (unless already done) so we can pull this contribution? http://www.restlet.org/community/contribute

Thanks for the contribution :)

@rmetzger

Thank you very much for the comments. Sadly, I don't have a lot of time these days. I'll see what I can do but I guess it takes at least two weeks till I find time to finish the pull request. Sorry :(

@thboileau thboileau was assigned Jul 18, 2012
@jlouvel
Restlet member
jlouvel commented Jul 18, 2012

No problem for the delay. The highest priority is the signed JCA as we can try to handle to rest ourselves later on if necessary

@jlouvel
Restlet member
jlouvel commented Dec 20, 2012

Looking how simple the fix is, we'll just reimplement it ourselves so you don't have to provide a JCA.

@thboileau thboileau pushed a commit that referenced this pull request Dec 21, 2012
Thierry Boileau Added custom Content-Range units to the Range-Class (issue #618)). Re…
…ported by rmetzger.
5517833
@thboileau
Restlet member

Thanks for reporting this, I've updated the 2.2m1.
I agree that this does not concern the reading of ranges from the HTTP request. HTTP 1.1 servers are not required to support such ranges.

@thboileau thboileau closed this Dec 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.