Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important change in Docs in Utf8Json #1600

Merged
merged 1 commit into from Jul 15, 2021

Conversation

ShardulTiurwadkar
Copy link
Contributor

@ShardulTiurwadkar ShardulTiurwadkar commented Jun 18, 2021

All other includes of properties or other imp things are with grey background but here in this case Utf8Json wasn't there with grey background. It's a minor change but as a reader anyone can figure it out the difference. I hope you will consider this change as it is small but an important Visual change.

Description

This pull request does not any code related issue but particularly a display related important issue from Docs. All important words like properties are in grey color but Utf8Json does not have any grey background color and this difference can be spotted while reading the docs.

Purpose

This pull request is a: Bugfix (non-breaking change which fixes an issue)

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

All other includes of properties or other imp things are with grey background but here in this case Utf8Json wasn't there with grey background. It's a minor change but as a reader anyone can figure it out the difference. I hope you will consider this change as it is small but an important Visual change.
@alexeyzimarev alexeyzimarev merged commit 97febf9 into restsharp:dev Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants