Change AddDefaultParameter methods to be extension methods #311

Merged
merged 1 commit into from Aug 30, 2012

Conversation

Projects
None yet
2 participants
@Haacked
Contributor

Haacked commented Aug 10, 2012

The AddDefaultParameter methods of RestClient don't need access to any private members or fields. They only need access to the DefaultParameters which is defined on IRestClient.

By turning these into extension methods, the IRestClient interface is easier to implement and all implementations of IRestClient get the benefit of these methods, not just RestClient.

Change methods to be extension methods
Makes implementing a custom IRestClient easier since these methods don't
need to be reimplemented. They don't need access to any private methods
or fields.
@ayoung

This comment has been minimized.

Show comment Hide comment
@ayoung

ayoung Aug 13, 2012

Contributor

I'm fine with this change. It'll need a major version bump.

Contributor

ayoung commented Aug 13, 2012

I'm fine with this change. It'll need a major version bump.

@ayoung ayoung merged commit d70f9c9 into restsharp:master Aug 30, 2012

@ayoung

This comment has been minimized.

Show comment Hide comment
@ayoung

ayoung Aug 30, 2012

Contributor

Alright its in. Found it odd that there were merge issues for something this simple and noticed that your fork is ~7 mo behind. Rebase?

Anyways, thanks!

Contributor

ayoung commented Aug 30, 2012

Alright its in. Found it odd that there were merge issues for something this simple and noticed that your fork is ~7 mo behind. Rebase?

Anyways, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment