Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for deserializing arrays #457

Closed
wants to merge 2 commits into from
Closed

Added support for deserializing arrays #457

wants to merge 2 commits into from

Conversation

JordyLangen
Copy link

No description provided.

@JordyLangen JordyLangen mentioned this pull request Nov 4, 2013
Closed
@haacked
Copy link
Contributor

haacked commented Nov 4, 2013

What about the Json case? Might be nice to support it there too. :)

@JordyLangen
Copy link
Author

That surely would be nice. That would also require some refactering I think. You would need one base class for handeling the reflection part, and interface implementations for retrieving the values for properties.
I implemented the Array support because we needed it for a project I am currently working on. (Using RestSharp for calling 3 other REST(ish) webservices)

I might be worth looking into supporting Arrays for Xml and Json deserialisation. Might also be interresting to develop a JsonAttributeDeserializer. So much fun stuff to do, so little time :)

haacked
haacked reviewed Nov 4, 2013
View reviewed changes
RestSharp.sln
@@ -1,6 +1,8 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 2012
# Visual Studio 2013
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file doesn't belong in this PR.

@haacked
Copy link
Contributor

haacked commented Nov 4, 2013

Ok, this looks good to me. If someone else needs JSON support, they can contribute it themselves. Just revert the change to the .sln file please and I'll merge this. 😄

@JordyLangen
Copy link
Author

Updated the sln file. I think I'll look at the overall array deserialization tonight :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JordyLangen @haacked @mediaan-buildagent