FIX: sometimes system property values are not Strings

It happens with Boolean for instance
restx · Dec 21, 2014 · 9c5ffc4 · 9c5ffc4
1 parent 1a48982
commit 9c5ffc4
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/restx-core/src/main/java/restx/config/ConsolidatedConfigFactoryMachine.java b/restx-core/src/main/java/restx/config/ConsolidatedConfigFactoryMachine.java
@@ -46,7 +46,11 @@ protected RestxConfig doNewComponent(SatisfiedBOM satisfiedBOM) {
                  * RestxConfig at all.
                  */
                 for (Map.Entry<Object, Object> entry : System.getProperties().entrySet()) {
-                    elements.add(ConfigElement.of("system", "", (String) entry.getKey(), (String) entry.getValue()));
+                    // System properties are a Map which is not protected against adding non String entries
+                    // we simply ignore them
+                    if (entry.getKey() instanceof String && entry.getValue() instanceof String) {
+                        elements.add(ConfigElement.of("system", "", (String) entry.getKey(), (String) entry.getValue()));
+                    }
                 }
 
                 // now fetch elements coming from ConfigSuppliers