Request headers management #277
Merged
Conversation
Great job! I'm just wondering about the naming, wouldn't Same for the annotation, it's a good idea, we could also introduce similar annotations for path, query and context annotations, in which case I'm wondering what we should use. Maybe using names similar to jaxrs would be easier to understand: |
…re aliases for @param(kind=QUERY|PATH|CONTEXT)
43be8b6
to
891dbc1
OK, renamed updated PR description accordingly |
fcamblor
added a commit
that referenced
this pull request
Sep 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR to fix first part of #101 concerning request headers management
Those request headers will be handled exactly the same (such as
Optional
handling andJackson
deserialization) asPATH
orQUERY
parameters, following what has been prepared in PR #177 (better query parameters)2 different forms of definig request header will be available :
@HeaderParam
annotation :@Param
annotationBoth forms can be shown in samplest's
ParametersResource
:which will generate following
StdEntityRoute
code :