New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging restx archives #72
Conversation
… giving the jar file during instanciation and using Files.copy() instead of handling streams by hand
…rom a working directory
It would be a good thing to extract But I don't know where to put it. I don't think putting it inside |
Good job! I've reviewed the commits, everything seems fine to me. About what is packaged inside the app, maybe making that configurable would be nice. Maybe something very simple like making the list |
I'm ok with an optional command parameter such as About injected named string, I suppose you're talking about an entry in the |
Yes, something in the AppSettings. Then to override it you only need to On Fri, Mar 21, 2014 at 10:31 AM, Frédéric Camblor <notifications@github.com
Xavier Hanin |
Back on the topic. Ok then if I add an entry in the Would there be a shell mechanism allowing to provide current visited app classes in a dedicated classloader, thus allowing to create a |
That sounds like too much complexity for such little value. A better place On Sat, Mar 29, 2014 at 4:00 PM, Frédéric Camblor
Xavier Hanin |
Note that currently, in different shell commands, we rely on Maybe should we file an issue about this topic ? |
allowing to retrieve supported foreign (aka non restx) module descriptors in a given directory
…resent Because without these descriptor, the restx archive won't be a real restx archive (auto download of dependencies won't be possible during `restx app grab + app run`)
About the usage of |
And BTW the PR is fine for me like that, feel free to merge it, it's a nice feature! |
Concerning It would be more natural for external tools to depend on Drawback for this will be to add a dependency WDYT ? (if you're ok, I'll move the class before the release) |
I agree that its current location doesn't make it very easy to reuse, and that moving it to |
ok I'm fine with it. |
This is a follow up for #62
I provided a new
app archive
command, allowing to generate a restx archive.Some insight about the restx archive : the
hello-world
application generated from arestx app new
will generate something like this :ATM, I'm packaging sources files into the restx archive (because api doc might rely on it to display source contents)
For the same reason, I package the
src/test/*
file hierarchy.You can test it easily :
FYI, I just created a
maven-restx-plugin
which will re-use theRestxArchive.pack()
utility method, in order to package a standard restx archive (with-restx
classifier).Important note : having the *.class files in the archive is totally useless since the first thing I do in
app grab
is to unzip & chroot to META-INF/restx/app/ directory (then, auto compile does the stuff for us).