Merged
Conversation
- Lots of Arbitrary instances Elected to use orphans for Text and Natural. Might be better to use newtypes throughout our models with proper (if derived) instances. - Lots of HasDependencies - Rewrite Factories genFoo functions easy node creation only if it's cumbersome (e.g. genJob) and should not do anything in particular with the generated model, except for system-wide invariants (such as genUser ensuring the dummy credsPlugin). Instead, prefer setFooBar as re-usable combinators for edit.
Prefer always generating a User then authenticating, vs wrapping up the two together. Make it easy to generate an Admin, so we don't need separate authentication functions for each.
pbrisbin
force-pushed
the
pb/graphula
branch
from
1b7ade8 to
8c796a3
Compare
Latest weeder has --require-hs-files, which obviates this. freckle/stack-action doesn't pass this flag, but we can make that so the next time a removed module bites us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.