Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix paging of starred repos. #162

Merged
merged 1 commit into from Dec 6, 2013

Conversation

Projects
None yet
3 participants
Contributor

trans commented Dec 2, 2013

I believe this will fix the paging issue with checking to see if a user has starred the resume.github.com repo. (P.S. I contacted GitHub support about adding an API for unauthenticated checking star status of a single repo. They said they'll look into it but gave no time-frame promises.)

Owner

davidcoallier commented Dec 5, 2013

This only looks for 1 more page right?

If we are adding pagination, shouldn't it paginate until it finds a repo?

What I mean is, what if there are 3 pages?

obfusk commented Dec 5, 2013

Looks fine to me. If the repo isn't found (and the page isn't empty) github_user_starred_resume(username, page + 1) is called recursively.

- Felix

davidcoallier pushed a commit that referenced this pull request Dec 6, 2013

Merge pull request #162 from trans/master
Fix paging of starred repos.

@davidcoallier davidcoallier merged commit 177b3b8 into resume:master Dec 6, 2013

obfusk commented Dec 7, 2013

Closes #161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment