Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upHelper Implementations for COM Types #98
Comments
This comment has been minimized.
This comment has been minimized.
|
Not worth doing because that's a lot of typing. |
retep998
closed this
May 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
randomPoison commentedMay 18, 2015
Winapi-rs has has support for COM types through manually declaring the vtable, but I've noticed that using these types is pretty nasty compared to doing so in C (see this example). This could be greatly simplified by adding an impl to the various COM types that wrap up the calls to the vtable functions. I've started implementing this on my fork (see this commit), but I wanted to get some feedback before making a pull request. Is this sort of change in line with the design ethos of winapi-rs? It seems like the idea is to only provide the C bindings to the Windows APIs, so this starts to go beyond that in providing a wrapper around the C bindings to provide a cleaner API. The reason I still think this is a good idea is that it recreates the C++ API that COM is supposed to have, which I would argue still adheres to the design ethos of winapi-rs.
Let me know what you think. If this seems like something worth doing I can make PRs as get things put together.