Feature/bluetooth #753
Merged
Feature/bluetooth #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wodann
force-pushed
the
feature/bluetooth
branch
2 times, most recently
from
88e2d73
to
e4f52e4
Compare
|
Rebased PR to include latest commits on |
Wodann
force-pushed
the
feature/bluetooth
branch
from
e4f52e4
to
e6f8ebd
Compare
|
Rebased again to incorporate v0.3.7 release. The release of my crate is being blocked by this PR. @retep998 If you don't think it is possible to review this PR in the short-term, I'll just have to publish my forked version of the winapi crate. I've investigated other options, but there is unfortunately no other way.. |
retep998
requested changes
Apr 17, 2019
Wodann
force-pushed
the
feature/bluetooth
branch
from
e6f8ebd
to
36e3a19
Compare
|
Thank you for your review @retep998. I fixed all of the issues you pointed out, and did the same in places where I found similar issues. I hope the updated PR is up to your standards. I also rebased the PR on top of your latest commit in the |
retep998
approved these changes
Jun 3, 2019
CypherNaught-0x
pushed a commit
to CypherNaught-0x/io-bluetooth-rs
that referenced
this pull request
Feb 3, 2020
Removed winbluetooth since, as per retep998/winapi-rs#753 it's now integrated in winapi. The version of winapi was also bumped one minor release to the newest version. No other changes were neccesary due to precise use imports.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of PR #604 that adds the ws2bth.h which is necessary for making a Windows implementation of Bluetooth sockets.
Credits to @Jarcho for all of the initial work.