Documentation update, use correct import fo go-check and resolve IsNil issue in One #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 12, 2014 11:04
gocheck package moved to github and should be referenced as gopkg.in/check.v1 https://github.com/go-check/check Update wercker to use gopkg.in/check.v1
`cursor.One` is a higher level funcion to get a single element from the result set. It already returns `ErrEmptyResult`, so to be consistent with a function responsibility it should also return that error even when user didn't check `IsNil` before performing `One`.
Collaborator
|
Thanks for these changes, I agree the |
dancannon
added a commit
that referenced
this pull request
Aug 12, 2014
Documentation update, use correct import fo go-check and resolve IsNil issue in One
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits messages are quite descriptive.
gocheck package has been moved to github, and it should be (according to it's author) referenced by gopkg.in/check.v1
In last commit, I've changed a bit behaviour of
cursor.One. For me it was'nt clear that I need to callIsNilevery time I'm usingOne. SinceOnelooks to be more higher level, and already usesErrEmptyResultthen it's logical that it should also support empty results as is.