Fix struct alignment for ARM and x86-32 builds #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you very much for finding this bug and creating a fix as well, its probably not something I would have discovered for quite a while. I will merge this change to |
Collaborator
|
Your PR has been merged to develop. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic.AddInt64 requires struct fields to be 64-bit aligned on x86-32 and ARM architectures. The token field of the Connection struct was not aligned and thus resulted in a nil pointer dereference. See the documentation on the Atomic package for reference: https://golang.org/src/sync/atomic/doc.go#L50