New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp LRU cache #6562

Merged
merged 1 commit into from Dec 10, 2017

Conversation

Projects
None yet
1 participant
@srh
Copy link
Contributor

srh commented Dec 10, 2017

Description

Fixes #6202. Replaces #6203. This is basically the fix pushed in #6207.

Revamp LRU cache
Has the effect of fixing the bug in the LRU cache where

(a) it doesn't actually cache non-empty keys
(b) the empty key's entry gets pointed at the most recent non-empty value

@srh srh added this to the 2.4 milestone Dec 10, 2017

@srh srh merged commit 3e8c6d8 into rethinkdb:next Dec 10, 2017

@srh

This comment has been minimized.

Copy link
Contributor

srh commented Dec 10, 2017

Also cherry-picked to v2.4.x with 1e5ef1f.

@srh

This comment has been minimized.

Copy link
Contributor

srh commented Dec 10, 2017

Note the comment at https://github.com/rethinkdb/rethinkdb/pull/6203#issuecomment-350584621 about backwards compatibility.

@srh srh deleted the srh:sam/lrucacherevamp branch Dec 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment