fix: do not depend on package to get the version #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 85410ce and detected 0 issues on this pull request. View more on Code Climate. |
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
gabor-boros
force-pushed
the
gabor/fix-package-versioning
branch
from
5472fa5 to
85410ce
Compare
lsabi
approved these changes
Dec 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
Fixes #309 and unblocks #311
Description
The way we read the package version is depending on the package itself, hence pip cannot install the packages that are listed in
install_requires. The reason we didn't encounter this issue yet is thatsixis required by many packages, hence it was already installed for target systems.Code examples
To check the fix working:
pip install .pip install .Checklist
References
N/A
cc: @srh