New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage reporting. #6

Merged
merged 5 commits into from Jul 25, 2018

Conversation

Projects
None yet
5 participants
@grandquista
Copy link
Contributor

grandquista commented May 31, 2018

Description

Adds Travis steps to export coverage data to Coveralls.

@chovy

chovy approved these changes Jul 2, 2018

Copy link

chovy left a comment

lgtm

@grandquista

This comment has been minimized.

Copy link
Contributor

grandquista commented Jul 2, 2018

I still need to come back to this and explore why coveralls is pending.

grandquista added some commits May 31, 2018

@grandquista grandquista force-pushed the grandquista:coveralls branch from 0ecbce6 to c714dae Jul 18, 2018

@grandquista

This comment has been minimized.

Copy link
Contributor

grandquista commented Jul 18, 2018

Rebased to remove v8 diffs from this PR.

@thelinuxlich thelinuxlich requested a review from atris Jul 18, 2018

README.md Outdated
@@ -3,6 +3,7 @@
[RethinkDB](https://www.rethinkdb.com)
======================================

[![Coverage Status](https://coveralls.io/repos/github/RebirthDB/rebirthdb/badge.svg?branch=next)](https://coveralls.io/github/RebirthDB/rebirthdb?branch=next)

This comment has been minimized.

@floydkots

floydkots Jul 19, 2018

Member

@grandquista, if it won't be too far outside this PR's scope, would you add the Travis build status badge too?

@atris

This comment has been minimized.

Copy link
Contributor

atris commented Jul 19, 2018

Looks good, I can merge now unless @grandquista wants to address @floydkots comments

@grandquista

This comment has been minimized.

Copy link
Contributor

grandquista commented Jul 19, 2018

Addressed the missing badge. I'm good with this being merged now.

@gabor-boros

This comment has been minimized.

Copy link
Member

gabor-boros commented Jul 25, 2018

Can we merge this PR?

@atris

atris approved these changes Jul 25, 2018

@atris atris merged commit 3e68442 into rethinkdb:next Jul 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on coveralls at 0.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment