Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Port RethinkDB web interface to ES6 #6262

Closed
wants to merge 8 commits into from

Conversation

@kvz
Copy link

kvz commented Feb 15, 2017

Hey there, there's been some talk on #open-rethinkdb that it would be a good idea to port the web interface from CoffeeScript to ES6. I have recently released a tool that helps with this, and I decided to run it on the webui.

Having read the README.md it wasn't immediately apparent to me how to run the project locally, so that should tell you what stage this is in: a work in progress and by no means ready to be merged ⚠️ .
I just thought I'd submit it already so it is known we can automate most of this, and focus our discussion/efforts.

Todos

  • Port Gulp to npm run scripts
  • Run (tests) and hammer out issues
  • Fix all remaining eslint issues:

screen shot 2017-02-15 at 10 54 56

@AtnNn

This comment has been minimized.

Copy link
Member

AtnNn commented Feb 15, 2017

Thanks doing this. There's been a lot of talk about moving to ES6 but this is the first attempt I've seen.

Note to others: this does not build. gulp does not terminate.

@AtnNn AtnNn added this to the subsequent milestone Feb 15, 2017
@AtnNn AtnNn added the cp:web-ui label Feb 15, 2017
@kvz

This comment has been minimized.

Copy link
Author

kvz commented Feb 15, 2017

@AtnNn

This comment has been minimized.

Copy link
Member

AtnNn commented Apr 30, 2017

@kvz I just put my changes up here #6344

@kvz

This comment has been minimized.

Copy link
Author

kvz commented May 1, 2017

Excellent! I'll keep following that PR and see when it lands, then redo my work here.

@kvz

This comment has been minimized.

Copy link
Author

kvz commented May 10, 2017

Okay as a quick headsup: #6344 was merged so I'll get the new webui to work on my machine, and then redo the work that was pending in this PR in a new one. Closing this one for now.

@kvz kvz closed this May 10, 2017
@kvz

This comment has been minimized.

Copy link
Author

kvz commented May 15, 2017

I was looking to work on this today, but after checking out things locally I noticed a gulp-based build architecture. Upon investigation I found:

commit caf72d78abc6e932729d8e6d05a434b45c9f7ea6
Author: Sam Hughes <sam@samuelhughes.com>
Date:   Fri May 12 13:34:32 2017 -0700

    Reverts web ui changes that break the build.

    Revert "add missing shebang"
    This reverts commit 7c28c93abb10c45adc4d255b8d7ab10b9e6d5bc8.

    Revert "wrap the npm binary to use the correct node.js"
    This reverts commit d64516c5d77d71679915cb0f69b57ba009d34eb3.

    Revert "Merge branch 'webui' into 'next'"
    This reverts commit 3710301531a78d6dd867d14fe7631a6b6b3c1f26, reversing
    changes made to 44a4e32a857022a3b1627d16cf43746eae456b0b.

Am I correct to conclude that work I need to base the es6 port on has been reverted and I'm to wait a bit longer?

@AtnNn

This comment has been minimized.

Copy link
Member

AtnNn commented May 15, 2017

@kvz feel free to checkout the commit before the revert and base your changes on that.

I'll push those changes back as soon as I fix some of the build issues they caused. However building the stand-alone web UI with npm works fine.

@kvz

This comment has been minimized.

Copy link
Author

kvz commented May 31, 2017

Thanks @AtnNn! Since I already jumped the gun earlier and am scared of doing three ports (or running into subtle merge conflicts), I'd feel safer committing to another run once the dust has settled in master a bit, hope you understand! 😸

@AtnNn AtnNn modified the milestones: old-prs, subsequent Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.