[WIP] Port RethinkDB web interface to ES6#6262
[WIP] Port RethinkDB web interface to ES6#6262kvz wants to merge 8 commits intorethinkdb:nextfrom kvz:next
Conversation
|
Thanks doing this. There's been a lot of talk about moving to ES6 but this is the first attempt I've seen. Note to others: this does not build. |
|
Correct, this is a raw code port so far. For others reading this: we're on slack in #webui talking about the next steps to take (perhaps basing the port on @AtnNn's standalone webui (https://github.com/AtnNn/rethinkdb-webui) which uses npm scripts vs gulp)
… On 15 Feb 2017, at 19:09, Etienne Laurin ***@***.***> wrote:
Thanks doing this. There's been a lot of talk about moving to ES6 but this is the first attempt I've seen.
Note to others: this does not build. gulp does not terminate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Excellent! I'll keep following that PR and see when it lands, then redo my work here. |
|
Okay as a quick headsup: #6344 was merged so I'll get the new webui to work on my machine, and then redo the work that was pending in this PR in a new one. Closing this one for now. |
|
I was looking to work on this today, but after checking out things locally I noticed a gulp-based build architecture. Upon investigation I found: Am I correct to conclude that work I need to base the es6 port on has been reverted and I'm to wait a bit longer? |
|
@kvz feel free to checkout the commit before the revert and base your changes on that. I'll push those changes back as soon as I fix some of the build issues they caused. However building the stand-alone web UI with |
|
Thanks @AtnNn! Since I already jumped the gun earlier and am scared of doing three ports (or running into subtle merge conflicts), I'd feel safer committing to another run once the dust has settled in master a bit, hope you understand! 😸 |
Hey there, there's been some talk on #open-rethinkdb that it would be a good idea to port the web interface from CoffeeScript to ES6. I have recently released a tool that helps with this, and I decided to run it on the webui.
Having read the⚠️ .
README.mdit wasn't immediately apparent to me how to run the project locally, so that should tell you what stage this is in: a work in progress and by no means ready to be mergedI just thought I'd submit it already so it is known we can automate most of this, and focus our discussion/efforts.
Todos