CSS linting integrated into pre-commit (apache#8218)

retornam · Apr 9, 2020 · 6aa4f53 · 6aa4f53
1 parent 08c9b0a
commit 6aa4f53
Show file tree

Hide file tree

Showing 11 changed files with 2,190 additions and 862 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -348,3 +348,10 @@ repos:
         entry: "./scripts/ci/pre_commit_bat_tests.sh"
         files: ^breeze$|^breeze-complete$|\.sh$|\.bash$
         pass_filenames: false
+      - id: stylelint
+        name: stylelint
+        entry: "stylelint"
+        language: node
+        files: ^airflow/www/.*\.(css|scss|sass)$
+        # Keep dependency versions in sync w/ airflow/www/package.json
+        additional_dependencies: ['stylelint@13.3.1', 'stylelint-config-standard@20.0.0']
diff --git a/.rat-excludes b/.rat-excludes
@@ -13,6 +13,8 @@
 .eslintignore
 .flake8
 .rat-excludes
+.stylelintignore
+.stylelintrc
 requirements
 requirements.txt
 .*log

diff --git a/STATIC_CODE_CHECKS.rst b/STATIC_CODE_CHECKS.rst
@@ -98,6 +98,8 @@ require Breeze Docker images to be installed locally:
 ----------------------------------- ---------------------------------------------------------------- ------------
 ``shellcheck``                        Checks shell files with shellcheck.
 ----------------------------------- ---------------------------------------------------------------- ------------
+``stylelint``                         Checks CSS files with stylelint.
+----------------------------------- ---------------------------------------------------------------- ------------
 ``update-breeze-file``                Update output of breeze command in BREEZE.rst.
 ----------------------------------- ---------------------------------------------------------------- ------------
 ``yamllint``                          Checks yaml files with yamllint.

diff --git a/airflow/www/.stylelintignore b/airflow/www/.stylelintignore
@@ -0,0 +1,2 @@
+node_modules
+static/dist/
diff --git a/airflow/www/.stylelintrc b/airflow/www/.stylelintrc
@@ -0,0 +1,3 @@
+{
+  "extends": "stylelint-config-standard"
+}
diff --git a/airflow/www/package.json b/airflow/www/package.json
@@ -51,6 +51,8 @@
     "mini-css-extract-plugin": "^0.4.1",
     "moment-locales-webpack-plugin": "^1.2.0",
     "style-loader": "^0.21.0",
+    "stylelint": "^13.3.1",
+    "stylelint-config-standard": "^20.0.0",
     "url-loader": "^1.0.1",
     "webpack": "^4.16.3",
     "webpack-cli": "^3.1.0",