Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No subtitles on tv4, Sjuan, tv12 se #1188

Closed
basrieter opened this issue Aug 9, 2019 · 17 comments

Comments

@basrieter
Copy link
Collaborator

commented Aug 9, 2019

Original report by Johan Gustavsson (Bitbucket: 6615, ).


Hi, Why are NO subtitles showing on the TV4 channels (TV4, Sjuan, and TV12)

I know they have changed their api, but it should still be possible to show the subtitles…

(look at https://uwtd.me for help)

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Duplicate of #986.

@basrieter basrieter closed this Aug 9, 2019

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Please search

@SYSophie

This comment has been minimized.

Copy link

commented Aug 28, 2019

If there are issues with subtitles from Bonnier Broadcasting (tv4play,cmore) etc I would suggest looking into svtplay-dl how it has been fixed there with parsing of segmented webvtt subtitles.

Sample manifest of segmented subtitle:
https://lbs-usp-hls-vod.cmore.se/vod/41624/tme3g3tbnki(11990130_ISMUSP).ism/tme3g3tbnki(11990130_ISMUSP)-textstream_swe=3000.m3u8

Sample segment:
https://lbs-usp-hls-vod.cmore.se/vod/41624/tme3g3tbnki(11990130_ISMUSP).ism/tme3g3tbnki(11990130_ISMUSP)-textstream_swe=3000-1.webvtt

Sample of complete webvtt (NOT segmented) - Hopefully this is easier to adopt
https://lbs-usp-hls-vod.cmore.se/vod/41624/tme3g3tbnki(11990130_ISMUSP).ism/tme3g3tbnki(11990130_ISMUSP)-textstream_swe=3000.webvtt

Last URL contains the entire subtitle and it isn´t chopped up into segments like the other samples and I can only assume that the issue is that there's no support for segmented webvtt subtitles? If this is the case then please consider going the easy way and use the last sample to adopt support for subtitles again.

I hope this helps!

Best regards,
S.Y-Sophie
Moderator @ uwtd.me

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 28, 2019

Ok, that makes things more interesting, as it would allow me to get an unsegmented webvtt.

@basrieter basrieter reopened this Aug 28, 2019

@basrieter basrieter added this to To do in Retrospect Development via automation Aug 28, 2019

@basrieter basrieter added this to the v5.0.5 milestone Aug 28, 2019

@SYSophie

This comment has been minimized.

Copy link

commented Aug 28, 2019

@basrieter Great 🚀👍

@Sopor

This comment has been minimized.

Copy link

commented Aug 30, 2019

Why is every dialog twice in the webvtt?

00:21:19.360 --> 00:21:20.000
–Jag har ett möte med Charles.
–Om vadå?

00:21:20.000 --> 00:21:23.640
–Jag har ett möte med Charles.
–Om vadå?
@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 30, 2019

They seem to just extend each other. I don't think you will notice. But I will check that once I start fixing this.

@orfeous1

This comment has been minimized.

Copy link

commented Aug 30, 2019

Finally, this is really great news! :)

@Sopor

This comment has been minimized.

Copy link

commented Aug 31, 2019

I downloaded a subtitle and tested it and it seems to work perfect 👍

@SYSophie

This comment has been minimized.

Copy link

commented Aug 31, 2019

@Sopor the double, triple or more occurrences are created due to that these webvtt files are parsed from the fragmented segments into one file and I guess the parser isn't merging similar lines. You won't see any difference in the final result. Sure the file is slightly bigger 50% or more then it would need to be but today I don't think this is an issue since these file are still very "light". This is an easier road to go to implement then to start parsing the segments and create a webvtt file or syncing them to each corresponding video/audio segment.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 31, 2019

Please use this zip and manually replace the Retrospect files with the newer versions inside the zip. Finally restart Kodi:

retrospect-patch-20190831.120625.zip

@basrieter basrieter moved this from To do to In progress in Retrospect Development Aug 31, 2019

@Sopor

This comment has been minimized.

Copy link

commented Aug 31, 2019

Everything seems to work as it should on all 3 channels except Hardcore Pawn: Pantbanken on TV12. It takes very long time to start an episode and there is no subtitle on some of the episodes.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 31, 2019

Good to hear. No issue here with Hardcore Pawn:

image

What episode?

@Sopor

This comment has been minimized.

Copy link

commented Aug 31, 2019

I believe it was ep 12 from 2019-08-12 and why will it take so long time before it starts?

I assume nothing has to do with Retrospect ...

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 31, 2019

Indeed, their server has a very slow response. Was over 10 seconds here. Can't help that.

@basrieter basrieter closed this in dde8c67 Aug 31, 2019

Retrospect Development automation moved this from In progress to Done Aug 31, 2019

@SYSophie

This comment has been minimized.

Copy link

commented Sep 1, 2019

@basrieter nice work 👍

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 1, 2019

I won't be pushing a separate update for this. But it will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.