Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A-Z listing for Swedish Channels #1193

Closed
basrieter opened this issue Aug 16, 2019 · 17 comments

Comments

@basrieter
Copy link
Collaborator

commented Aug 16, 2019

Original report by eefew rwgheh (Bitbucket: strawberryreal, ).


I was wondering if you could add an option that make one folder of the individual folders a,b,c,d,…,z. In that way the first page will be much more clean for each channel, for instance tv4. The folder can be named A-Ö. When you click it you are presented with a list of all the folders a,b,c,d,…,z.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


There is a Retrospect setting called “Group items if exceeds …”. Set it to a low value and Retrospect will automatically group large lists based on their first character. I think is what you mean?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by eefew rwgheh (Bitbucket: strawberryreal, ).


I have tried this setting with no luck using max 10 and version 5.02 from the official kodi repository. When you click tv4 play you are taken to the main page for the channel. There are folders named “titles with a,b,c,…,z”. I was wondering if it is possible to group these folders into one folder named “Program A-Z”. This will make the main page for each channel much more clean. The screenshot below shows a part of the main page for tv4 play.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


I understand now. Instead of mixing the listings shows with the other fixed items, like Sok and Kategorier, you would like them nested in a folder. Could you check the NPO Start channel (Dutch), I think it has what you are suggesting.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by eefew rwgheh (Bitbucket: strawberryreal, ).


Yes, that is exactly what i am looking for.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


I can do it like this:


Would that make sense? The “Programmen” would lead you to the other programs. Either grouped by first char, or the complete list.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by eefew rwgheh (Bitbucket: strawberryreal, ).


Yeah, that looks perfect.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Please use this zip and manually replace the Retrospect files with the newer versions inside the zip. Finally restart Kodi.

Let me know if the result is OK.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by eefew rwgheh (Bitbucket: strawberryreal, ).


It works without any problems. Thank you for the fast response and help!

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Great! I will add this to the next Retrospect versions. But given the fact that I need to get each version into the official Kodi repository I am planning to not do this every day, but rather to gather up some changes and submit them simultaniously.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Changed: restructured the TV4 Play main list a bit (Fixes #1193)

@basrieter basrieter closed this Aug 17, 2019

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


I would suggest naming it “Program A-Ö” instead.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 17, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Nope, as the listing is grouped based on the settings the user has.

@Snaah

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

I can't find an option for this. Am I missing something here? To me it seems that now it is always necessary with the extra step "Programmen" to browse the actual shows. I see the point of having this as an option, but not "hard coded".

Sorry for bugging you, but I got to say again "Programmen" feels awkward language wise. It has the definite article, ie "The Programs" which sounds strange as most labels otherwise have the indefinite article. In Kodi, for instance, it's "Music", "TV", "Add-ons", "Pictures" etc, not "The Music", "The TV(-programs)", "The Add-ons", "The Pictures" (likewise in Swedish). I still suggest to change it to "Program A-Ö". This is also what TV4 uses, see top page of https://www.tv4play.se/ But no biggie, of course. If I've convinced you, I can add it to a future language fix PR. :)

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2019

@Snaah indeed, you need to navigate to "Programmen" now. And then, taking the settings of Retrospect into account (group if list size exceeds), it will either how A-Z, or all the shows. This is similar to the NPO Start channel.

@Snaah

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

@basrieter How about making it an option? Something "Group all programs of each channel into a folder". Could be connected to the settings (group by list size), like option "Yes, always", "Yes, if programs exceed [number]. Not sure what is the best not to be confusing.

"Program A-Ö"? :p I can do the minimal language PR later on so you can decide then. NRK TV has the same structure and just "A-Å" (should perhaps be changed to "Programmer A-Å". Also, the alphabetic sorting is not correct for the letters Æ, Ø and Å.)

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 23, 2019

I don't really like the settings based solution, as it makes the code too complex. I basically need to take two completely different scenarios in mind, that might or might not require extra data retrieval. So that is not an option. I think I will move each channel with that many "generic" items to the same structure in the future, as it is much easier to find stuff.

Regarding the Program A-Ö:" this is not correct as the grouping depends on the user settings. It actually needs to be the translation of the English "TV Shows".

For NRK that is different, as they have the A-A structure online, so the grouping has to be done and cannot depend on the user.

But I general, whats I will for the changes that require this kind of discussion I will include you guys during the coding so we can get a common view on things.

@Snaah

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

You're right about the "A-Ö" part. Didn't think about that it will be incorrect if the sorting is not by name. "TV Shows" is "TV-program" in Swedish ("program" is both singular and plural). With definite article, ie "The TV Shows" it is "TV-programmen".

I think a setting for grouping or not grouping the shows would be good though. Couldn't the code for grouping shows if it exceeds [x] be used?

NRK: Ok, I see they only have alphabetical sorting now. I discovered the sorting of Æ, Ø and Å is (of course) done by Kodi's language settings. Changing to Norwegian it is correct, and I think that is what matters most.

Great! I'll be glad to participate, and the more we are, the better the base for your decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.