Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles does not work as they should #1204

Closed
basrieter opened this issue Aug 19, 2019 · 25 comments

Comments

@basrieter
Copy link
Collaborator

commented Aug 19, 2019

Original report by Snah (Bitbucket: Snaah, GitHub: Snaah).


If Retrospect is set to show subtitles when starting a program, subtitles are shown. It is possible to turn the subtitles on and off, just like it should be. If Retrostpect is set to not show subtitles and I try to turn them on in the program, it doesn't work at all.

Tested TV6 - Border security. First set to show subtitles, then not.
Aktuellt, vice versa.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Nope, that is exactly the behaviour I had in mind. It does even try to use subtitles if you disable them.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


I think maybe you misunderstood.
When Retrospect is set to never show subtitles, it is impossible to turn them on.
When Retrospect is set to show subtitles if there are any, it possible to turn them off.

Is this how you want it?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Exactly.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


But that is not how it is in Kodi. I mostly don’t have subtitles on as I don’t need it for Swedish, but sometimes I want it. Most of the times subtitles for movies are hardcoded, but many aren’t. Wouldn’t it be easier to have it work like for Kodi, that you can turn them on and off without going to settings to activate “Show if there are subtitles”? Then the setting could be “Show subtitles as default” with the options “yes”/”no”.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Please use this zip and manually replace the Retrospect files with the newer versions inside the zip. Finally restart Kodi.

See if the behaviour makes more sense then.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


Yes, this is exactly my thought! You are fast as a shark, like the metal band Accept sang. 😀 Change the settings string?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


What would you suggest?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


English
Setting label: “Show subtitles as default if they are available”
Options: “Yes” and “No”

**Swedish
**Setting label: “Visa undertexter som standard om de finns”
Options “Ja” and “Nej”

Is that good?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


I don’t want to change the type of the setting (too much work). I would change it to: “Subtitles enabled: if available/disabled”

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


It’s the “disabled” part that’s bugging me there. Very much work to make the string type yes or no? Your suggestion is similar to the present wording. Keep it like your patch and change the type when you have time?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


I will make it: "Show subtitles whenever they are available" what would that be in Swedish?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Changed: behaviour of enabling/disabling subtitles in Retrospect (Fixes #1204)

@basrieter basrieter closed this Aug 20, 2019

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


I would make it “if they are available”. Show subtitles if they are available=Visa undertexter om de finns.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Changed: behaviour of enabling/disabling subtitles in Retrospect (Fixes #1204)

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Ok, last try. Please try this version :)

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


Great with the button! How about:

“Show subtitles when available as default” (With the “as default” I think “when” is better not to confuse, so your word was better. :slight_smile: )

“Visa undertexter om de finns som standard”

I discovered now subtitles get out of sync if I skip forward or backward, doesn’t matter if Retrospect is set to show subtitles as default or not. But if I stop and restart the program subtitles are in sync. Tried on SVT, Öppet arkiv, TV6, TV3. Maybe not Retrospect related?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


I don’t really get the “default” part in your suggestion?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


Because setting it to disabled doesn’t make it obvious you can still show them by the setting in the player?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


So, then “Enable subtitles when available” would make more sense?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


I’m thinking like this out of a Kodi newcomer’s perspective: Enable? Ok, then I must have this on to get subtitles at all. While “…as default” makes me understand I can set this to off, but still get subtitles if I want them.

But hey, I’m not a Kodi newcomer, so I might be wrong. It’s no biggie, so it can be changed later. We could hear what @{557058:f9491234-941e-4b6d-b222-8e6ea5c1a4d8} or @{557058:e1509cf4-2a87-49a9-8a34-25718017cc82} thinks?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


Enable subtitles by default when available?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


Sure! “Aktivera undertexter som standard om de finns”.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


Forgot: What about the out of sync? Not related to Retrospect?

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

Original comment by Bas Rieter (Bitbucket: basrieter, GitHub: basrieter).


nope, that is a Kodi/InputStream thing.

@basrieter

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 21, 2019

Original comment by Snah (Bitbucket: Snaah, GitHub: Snaah).


Ok. Damn this awesome media system! 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.