Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More view-options #1268

Closed
user00099 opened this issue Dec 26, 2019 · 16 comments
Closed

More view-options #1268

user00099 opened this issue Dec 26, 2019 · 16 comments
Assignees
Labels
Milestone

Comments

@user00099
Copy link

@user00099 user00099 commented Dec 26, 2019

Feature Request

Is your feature request related to a problem? Please describe

I'm using the Kodi-skin Estuary which have 9 view-options (List, Poster, IconWall, Shift, InfoWall, WideList, Wall, Banner, FanArt), but in the Retrospect-addon I only can see WideList, InfoWall and Wall.

Describe the solution you'd like

If its possible and not to much work, it would be nice with some more view-options, especially FanArt-view (View 502)

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 27, 2019

Please use this zip and manually replace the Retrospect files with the newer versions inside the zip. Finally restart Kodi and see if this is better:

  • removed -
@basrieter basrieter self-assigned this Dec 27, 2019
@basrieter basrieter added this to To do in Retrospect Development via automation Dec 27, 2019
@basrieter basrieter added this to the v5.1.4 milestone Dec 27, 2019
@Snaah

This comment has been minimized.

Copy link
Contributor

@Snaah Snaah commented Dec 29, 2019

Gives error and Retrospect doesn't start:

20191229 01:07:40 - [DEBUG ] - envcontroller.py - 111 - + G:#Skräp\Kodi2\portable_data\addons\plugin.video.retrospect\resources\media\retrospect03.jpg
20191229 01:07:40 - [DEBUG ] - xbmcwrapper.py - 195 - Showing notification: Retrospect - Startar Retrospect.
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - Error running plugin
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - | Traceback (most recent call last):
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - | File "G:#Skr䰜Kodi2\portable_data\addons\plugin.video.retrospect\resources\lib\addon.py", line 62, in run_addon
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - | plugin.Plugin(sys.argv[0], sys.argv[2], sys.argv[1])
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - | File "G:#Skr䰜Kodi2\portable_data\addons\plugin.video.retrospect\resources\lib\plugin.py", line 82, in init
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - | from resources.lib.updater import Updater
20191229 01:07:40 - [CRITICAL] - addon.py - 72 - + ImportError: No module named updater
20191229 01:07:40 - [INFO ] - addon.py - 73 - Retrospect :: Flushing and closing logfile.

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

Crap, let me fix that. I added the GIT version not the Repository version. The GIT version had an "new version found" notification.

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

@Snaah

This comment has been minimized.

Copy link
Contributor

@Snaah Snaah commented Dec 29, 2019

Working! Nice enhancement, very good suggestion @user00099

Noticed two things:

  1. SVT Play fanart looks strange:
    image

  1. While we're at the viewing options, is it possible to make the picture+text of the WideList option start at the same level as the List option, i.e. higher up on the page? This would remove the wait for the scrolling of text.

WideList:
image

WideList:
image

As always, great work, @basrieter !

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

So the Fanart of SVT is that actual image:

https://cdn.rieter.net/resource.images.retrospect/resources/channel.se.svt/svtfanart.jpg

The other 2 suggestions are skin things, over which I have no control I think.

@basrieter basrieter closed this in 836cd5c Dec 29, 2019
Retrospect Development automation moved this from To do to Done Dec 29, 2019
@user00099

This comment has been minimized.

Copy link
Author

@user00099 user00099 commented Dec 29, 2019

First, thanks for a great work with the Retrospect-addon.

Now also I have tested the patch with the FanArt-view and it works for me as well.
But is it possible to get the FanArt-pictures from each Play-channels website instead of the ones from the Retrospect-addon resources?
I have tested the SVT Play-channel in both Retrospect-addon and the SVT Play-addon from Kodis official repository, both with the FanArt-view, and it looks a little bit different from each other.
Here is some screenshots of both Retrospect-addon and the SVT Play-addon.

SVT Play-channel in Retrospect
Retrospect01

SVT Play-channel in SVT Play-addon
SvtPlayAddon01

SVT Play-channel in Retrospect
Retrospect02

SVT Play-channel in SVT Play-addon
SvtPlayAddon02

So if its possible and not to much work, it would be great if its possible to get the FanArt-pictures from each Play-channels website instead.

Thanks in advance.

@user00099

This comment has been minimized.

Copy link
Author

@user00099 user00099 commented Dec 29, 2019

Dplay-channel in Retrospect
Retrospect03

In this case the FanArt-picture is taken from Dplays website
Retrospect04

Retrospect05

TV4 Play-channel in Retrospect
Retrospect06

Retrospect07

Retrospect08

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

Well, it depends on what I code as to be "fanart". I don't set fanart for all shows. Let me check that too.

@basrieter basrieter reopened this Dec 29, 2019
Retrospect Development automation moved this from Done to In progress Dec 29, 2019
@user00099

This comment has been minimized.

Copy link
Author

@user00099 user00099 commented Dec 29, 2019

My default phrase: If its possible and not to much work -
it would be nice if you set fanart for all shows, and also set the fanarts to be taken from each Play-channels website. Especially Sweden: SVT Play, TV4 Play, Dplay and Viafree.

Thanks in advance.

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

So SVT I can fix, but not all the things I have listed provide all image data:

retrospect-patch-20191229.220651.zip

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 29, 2019

While looking at #1271 I found that allowing more views by setting the content type to "TV Shows" breaks the season/episode information in Kodi, as a TV Show does not have a specific season or episode. So the main question here is: Why and where do you want these views? Because I will have to revert it at least for the normal listings. I can keep this change for the channel overview.

@user00099

This comment has been minimized.

Copy link
Author

@user00099 user00099 commented Dec 30, 2019

Ok, didnt know that - not good if it breaks the season/episode information.
Hmm... - I like the FanArt-view but if it breaks the season/episode information maybe its better to keep using either List or WideList-view.
Maybe i'll go back to List or WideList instead, so maybe its unnecessarily for you to keep laying down works on it.

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 30, 2019

I asked around in the Kodi team Slack, but the view types from specific content types are determined by the skin.

So you could ask the skin author to add more view types for the "episodes" content type.

@Snaah

This comment has been minimized.

Copy link
Contributor

@Snaah Snaah commented Dec 30, 2019

Bummer. The episode/show information is more important.

@basrieter basrieter closed this Dec 31, 2019
Retrospect Development automation moved this from In progress to Done Dec 31, 2019
@basrieter basrieter removed the tobereleased label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.