Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTG channels - enhance look and feel #1272

Closed
matsarv opened this issue Dec 30, 2019 · 9 comments
Closed

MTG channels - enhance look and feel #1272

matsarv opened this issue Dec 30, 2019 · 9 comments
Assignees
Milestone

Comments

@matsarv
Copy link

@matsarv matsarv commented Dec 30, 2019

Feature Request

Is your feature request related to a problem? Please describe

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

No problem, just some small enhancements for a great product.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Some minor enhancement are requested and I will provide code for the requested changes below that I use on my own system.

  • Display program name with Title - SeasonEpisode
  • Display Fanart in video_item
  • Display Fanart to episode_item
  • Add expire date to description
  • Add "set_info_label" to show duration

mtgchannels-CodeForChange.txt

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@matsarv matsarv added the enhancement label Dec 30, 2019
@basrieter basrieter added this to the v5.1.4 milestone Dec 30, 2019
@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 30, 2019

Thanks again for these changes. I added all of them, but took a slightly different approach for the artwork:
chn_viafree.zip

@matsarv

This comment has been minimized.

Copy link
Author

@matsarv matsarv commented Dec 31, 2019

Everything works OK.

I found one thing that catch my eyes.

Image 5

A missing hyphen and upper case in Season and Episode to lower.

My opinion is to use upper case in Season and Episode. If you decide to go all in for upper case, please change this also in MTG and SE channels as this looks better.

Have a really good Happy New Year!

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Dec 31, 2019

The missing hyphens is because that is how it is in the JSON data:

image

@basrieter basrieter self-assigned this Dec 31, 2019
@Snaah

This comment has been minimized.

Copy link
Contributor

@Snaah Snaah commented Dec 31, 2019

@basrieter When this is released, you can also close #1205.

@matsarv

This comment has been minimized.

Copy link
Author

@matsarv matsarv commented Dec 31, 2019

OK, ready for release then.

@basrieter basrieter closed this in 55a730f Dec 31, 2019
basrieter added a commit that referenced this issue Dec 31, 2019
Added: Expire date for ViaFree (Fixes #1272)
Changed: Moved to sXXeXX for seasons for ViaFree (Fixes #1272)
@matsarv

This comment has been minimized.

Copy link
Author

@matsarv matsarv commented Jan 4, 2020

Since it's not release I will add this. Hope it's OK.
Above i mentioned the Season and Episode, missing hyphen, large S and E.

I did a small change and that fixed everything.

remark row 495
            # webisode = result_set.get("webisode", False)

replace row 498
from:
            if episode > 0 and not webisode:
to:
            if episode > 0:

I don't understand what the webiscode is used for.

Before change:
viafreeepisode1

After change:
viafreeepisode2

@Snaah

This comment has been minimized.

Copy link
Contributor

@Snaah Snaah commented Jan 4, 2020

@matsarv If you have the time you could take a look at #1231 (and possibly #1232 too). Would be great!

@basrieter

This comment has been minimized.

Copy link
Collaborator

@basrieter basrieter commented Jan 4, 2020

The webisode is used in some cases. Don't remember why. Will change it.

@matsarv If you have the time you could take a look at #1231 (and possibly #1232 too). Would be great!

This request makes little sense as it involves much more than just small changes. Just be patient until they are done.

basrieter added a commit that referenced this issue Jan 4, 2020
@matsarv

This comment has been minimized.

Copy link
Author

@matsarv matsarv commented Jan 4, 2020

@Snaah Would be nice to have genres not only for SVT. Sorry, this goes over my head and as @basrieter said "involves much more than just small changes".

@retrospect-addon retrospect-addon deleted a comment from Snaah Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.