Use the faster Buf.append instead of ~= #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterDuke17
force-pushed
the
master
branch
2 times, most recently
from
4a35f93
to
c6fbc0f
Compare
and call it directly so it doesn't have to be looked up for every call to Str.encode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine this is much faster and uses a lot less ram. For a 4.9m gzip file that unzips to 17m, just gzslurping it (with
:bin) decreased from ~9.5s and 6012364maxresident to ~0.7s and 155352maxresident. For the not:bincase, gzslurping it decreases from ~9.5s to ~7s.Passes all the tests.