Hide dangerously flag and remove kwargs #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwager
commented
Sep 2, 2021
| ) as target_file, tempfile.NamedTemporaryFile( | ||
| "w" | ||
| ) as equiv_file: | ||
| ) as rule_file, tempfile.NamedTemporaryFile("w") as target_file: |
There was a problem hiding this comment.
Unrelated - without equivalences we no longer need equiv_file. No need to open another file every run.
emjin
reviewed
Sep 2, 2021
|
🔥 Potential speedup in benchmark semgrep.bench.lodash.std: -30.5% (-2.105 s) 15 benchmarks, 2.5% faster on average. Individual deviations greater than 20% from the baseline are reported. An individual performance degradation of over 30% or a global degradation of over 7% is an error and will block the pull request. See run output for full results ('Show all checks' > 'Tests / semgrep benchmark tests' 'Details'). |
IagoAbal
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
pattern-where-pythonhas been removed we no longer need this flag. To maintain backwards compatibility, I've only suppressed it, not fully removed it. This means you can still run with the flag, but it's not visible in-hand won't actually do anything. I figured the less we havedangerously_allow_arbitrary_code_executionfloating around in the codebase the better.PR checklist: