Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix syntax error in misc_naming_recursion test #5529

Merged
merged 1 commit into from Jun 15, 2022
Merged

Conversation

nmote
Copy link
Collaborator

@nmote nmote commented Jun 14, 2022

I don't see anything in #2615 indicating that this syntax error was
intentional. The test still passes after this change.

PR checklist:

  • Documentation is up-to-date
  • Changelog is up-to-date
  • Change has no security implications (otherwise, ping security team)

I don't see anything in #2615 indicating that this syntax error was
intentional. The test still passes after this change.
@nmote nmote requested a review from aryx June 14, 2022 22:14
@aryx
Copy link
Collaborator

aryx commented Jun 15, 2022

weird, why CI was working before?

@aryx aryx merged commit ba145dd into develop Jun 15, 2022
@aryx aryx deleted the nmote/test branch June 15, 2022 07:19
@nmote
Copy link
Collaborator Author

nmote commented Jun 15, 2022

Not sure, but it failed when I tried to run DeepSemgrep on these tests which clued me in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants