fix(cli): git URL parsing for subgroups #7611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
y'all would have thought this was Lagrange's theorem, because today we're talking about subgroups
What:
This PR fixes URL parsing for URLs which have a "subgroup" structure, which is to say that it is in a "nested grouping structure". Previously, we would butcher these URLs, and produce things like
https://https//gitlab.com/r2cexamples2/group2/group3/chess-gamefromhttps://gitlab.com/r2cexamples2/group2/group3/chess-game.git.Why:
We want clickable URLs.
How:
Made it such that when parsing the "owner" of a project, it can include slashes (so it might be multiple such entries in the URL, instead of just one).
Test plan:
Added a test suite for git URL parsing, which we can use for the future.
I don't actually know what the end target URL is supposed to look like, but I presume it should look similar to what the working example is (which produces
https://gitlab.com/r2cexamples2/webgoatfromhttps://gitlab.com/r2cexamples2/webgoat.git)Closes PA-2669
PR checklist:
If you're unsure about any of this, please see: