Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the zizmor tool to lint and enforce policies on GitHub workflow YAMLs.
- Introduces a
zizmor.ymlconfig to allow an exception fordtolnay/rust-toolchain. - Adds a new
workflow-checks.yamlworkflow to run zizmor and upload SARIF results. - Updates existing workflows (
ci.yamlandci-reports.yaml) to suppress specific zizmor checks.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| zizmor.yml | Define unpinned-uses rule with policy exception for Rust toolchain |
| .github/workflows/workflow-checks.yaml | New workflow for running zizmor and uploading SARIF output |
| .github/workflows/ci.yaml | Add inline ignore for stale-action-refs on Homebrew action |
| .github/workflows/ci-reports.yaml | Add inline ignore for dangerous-triggers on PR reports workflow |
Comments suppressed due to low confidence (1)
.github/workflows/workflow-checks.yaml:29
- The comment says 'Install the latest version of uv' but the action is pinned to v6.0.1; consider updating the comment to reflect the pinned version or remove 'latest'.
- - name: Install the latest version of uv
| # We intentionally run this workflow in the context of the target of a PR; we are careful | ||
| # an intentional about how we handle the data coming from the PR. |
There was a problem hiding this comment.
There's a typo in this comment ('an intentional'); it should read 'and intentional' or be combined into a clearer single sentence.
| # We intentionally run this workflow in the context of the target of a PR; we are careful | |
| # an intentional about how we handle the data coming from the PR. | |
| # We intentionally run this workflow in the context of the target of a PR, and we are careful | |
| # about how we handle the data coming from the PR. |
Test Results 3 files 17 suites 3m 39s ⏱️ Results for commit a1ff35d. |
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
Adopts zizmor for checking our workflow YAMLs.