Skip to content

ci: fix pedantic warnings from newer zizmor release - #535

Merged
reubeno merged 1 commit into
mainfrom
more-zizmor
May 31, 2025
Merged

reubeno merged 1 commit into
mainfrom
more-zizmor

Conversation

@reubeno

@reubeno reubeno commented May 31, 2025

Copy link
Copy Markdown
Owner

These are largely focused on avoiding references to template expansions in the body of a run: property.

@reubeno
reubeno requested a review from Copilot May 31, 2025 00:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses pedantic warnings from the newer zizmor release by moving inline template expansions from run commands to environment variables.

  • Refactors inline substitutions for required tools, build arguments, and target values to environment variables.
  • Updates run command lines to use shell environment variable references instead of direct template expansions.

Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/ci.yaml Outdated
@github-actions

github-actions Bot commented May 31, 2025 •

Copy link
Copy Markdown

Test Results

    3 files     17 suites   3m 43s ⏱️
  771 tests   771 ✅ 0 💤 0 ❌
2 299 runs  2 299 ✅ 0 💤 0 ❌

Results for commit 570be67.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented May 31, 2025 •

Copy link
Copy Markdown

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 17.71 μs 18.28 μs 0.57 μs 🟠 +3.21%
eval_arithmetic 0.17 μs 0.17 μs 0.00 μs ⚪ Unchanged
expand_one_string 1.84 μs 1.84 μs 0.00 μs ⚪ Unchanged
for_loop 22.45 μs 22.29 μs -0.17 μs ⚪ Unchanged
function_call 2.35 μs 2.36 μs 0.02 μs ⚪ Unchanged
instantiate_shell 57.79 μs 58.04 μs 0.25 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 23848.38 μs 24183.84 μs 335.46 μs ⚪ Unchanged
parse_bash_completion 1664.49 μs 1675.68 μs 11.19 μs ⚪ Unchanged
parse_sample_script 1.84 μs 1.76 μs -0.08 μs 🟢 -4.13%
run_echo_builtin_command 15.44 μs 15.27 μs -0.17 μs ⚪ Unchanged
run_one_external_command 6859.71 μs 3657.54 μs -3202.17 μs 🟢 -46.68%
tokenize_sample_script 2.95 μs 2.92 μs -0.03 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/options.rs 🟢 93.48% 🟢 92.39% 🔴 -1.09%
Overall Coverage 🟢 75.01% 🟢 75% 🔴 -0.01%

Minimum allowed coverage is 70%, this run produced 75%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1299 61.59
❗️ Error 244 11.57
❌ Fail 181 8.58
⏩ Skip 370 17.54
❎ Expected Fail 15 0.71
📊 Total 2109 100.00

@reubeno
reubeno merged commit 347a303 into main May 31, 2025
@reubeno
reubeno deleted the more-zizmor branch May 31, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants