Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed debug values, supporting function with name #44

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@adamkleingit
Copy link
Collaborator

commented Jun 16, 2019

  • Support named functions automatically (name the store after them)
  • Name all of the components under ReusableProvider (because of minification)
  • Rename 'run' to 'value' for a better debug value
  • Use the store's name as a debug value inside consumers as well

@adamkleingit adamkleingit requested a review from morsdyce Jun 16, 2019

}

getValue() {
return this.cachedValue;
}

run() {
value() {

This comment has been minimized.

Copy link
@morsdyce

morsdyce Jul 7, 2019

Collaborator

having both getValue and value on the store is very confusing. maybe it would be better called as computeValue and getValue will be getCachedValue.

This comment has been minimized.

Copy link
@adamkleingit

adamkleingit Jul 7, 2019

Author Collaborator

value => useValue.
getValue => getCachedValue

@morsdyce

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

@adamkleingit can you fix conflicts?

@adamkleingit

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 13, 2019

@morsdyce done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.