Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] shapes.scad doesn't build because of syntax error in StaggeredSphere #86

Closed
watching-spd opened this issue Apr 30, 2021 · 5 comments
Assignees
Labels

Comments

@watching-spd
Copy link

Describe the bug
shapes.scad won't build because of a syntax error if StaggeredSphere is uncommented:

ERROR: Parser error in line 1982: syntax error 
ERROR: Compilation failed! 

Code To Reproduce Bug

include <shapes.scad>;

Expected behavior
shapes.scad should build and import cleanly.

Additional context
Add any other context about the problem here.

  • OpenSCAD Version: 2015.03-2, Windows 10 (wow, this is a truly ancient version of OpenSCAD...)
  • Other libraries used: None
@fe60
Copy link
Contributor

fe60 commented Apr 30, 2021

It works perfectly with OpenSCAD 2021.01 (and most probably does with 2019.05).
Is there a special reason for using such an old version of OpenSCAD?

@watching-spd
Copy link
Author

watching-spd commented May 1, 2021

No, there's no good reason! I just didn't realize until cutting this issue how out of date I'd let it get. :)

I've got a work-around (commenting out that module), but it might be nice to find the minimum supported version and throw a more useful error message in the case where the library uses newer language features?

@fe60
Copy link
Contributor

fe60 commented May 2, 2021

The error message is thrown by OpenSCAD. So there is nothing the library can do about it. And I'm not sure how OpenSCAD could handle this in a better way. It stumbles across an unknown statement and fails with "Syntax error". It can't know, it's a valid language feature in future versions.

I forked the git repository behind the wiki into a new one and started adding fixes. Its README declares OpenSCAD 2019.05 as minimum version.
Once I think it is a feasible approach to host the documentation in a separate repository, I will ask the owner/author of BOSL to move the wiki into a dedicated Github-Repo to allow wiki contributions from everyone.

@revarbat
Copy link
Owner

BOSL v1 wiki is now publicly editable.

@revarbat
Copy link
Owner

I recoded stagger_sphere() to avoid using each. It works with OpenSCAD 2015.03 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants