Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0.0 #6

Merged
merged 1 commit into from Oct 18, 2018
Merged

Version 1.0.0 #6

merged 1 commit into from Oct 18, 2018

Conversation

jwietelmann
Copy link
Contributor

closes #5

  • Removes file_input_stack, which never functioned like the Harmonium JS/CSS package version.
  • Applies properly-specific input stack CSS class names to HTML.
  • More doctests.

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited

Pull Request Test Coverage Report for Build 20

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 49.038%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/harmonium.ex 5 8 62.5%
Totals Coverage Status
Change from base Build 17: 4.3%
Covered Lines: 51
Relevant Lines: 104
💛 - Coveralls

@prehnRA prehnRA removed their assignment Oct 18, 2018
@bryanjos bryanjos merged commit 8b4b7ba into master Oct 18, 2018
@bryanjos bryanjos deleted the bug/5-stack-css-class-names branch October 18, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanjos bryanjos bryanjos approved these changes

@prehnRA prehnRA prehnRA approved these changes

Assignees

@bryanjos bryanjos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textarea_stack produces the wrong CSS class names
4 participants
@jwietelmann @coveralls @bryanjos @prehnRA