Skip to content
Browse files

Move post-review into a new top-level "rbtools" package

Since the dawn of time, post-review has lived in the Review Board tree, despite being a client script and not necessarily being needed on the server.

This moves post-review into a new rbtools package, which users will be able to easy_install (easy_install -U RBTools). The simplejson dependency will be fetched, and users won't have to go hunting in SVN for a script.

Over time, I'd like to add new scripts into here (such as one to apply a diff from a review request), and further down the road I'd like to create an "rbapi" (or something) package that contains a Python API for talking to a Review Board server, which rbtools (and post-review) will then use. For now, the goal is to just get post-review moved over.

Reviewed at
  • Loading branch information
chipx86 committed Mar 27, 2009
0 parents commit f5ec35fc2606a89034823ab15ccefb7e5bbe15c8
Showing with 2,722 additions and 0 deletions.
  1. +4 −0 AUTHORS
  2. +11 −0 INSTALL
  3. +4 −0
  4. 0 NEWS
  5. +13 −0 README
  6. +2 −0 contrib/P4Tool.txt
  7. +25 −0 contrib/README.P4Tool
  8. +272 −0
  9. +2,312 −0 scripts/post-review
  10. +14 −0 setup.cfg
  11. +65 −0
@@ -0,0 +1,4 @@
Lead Developers:

* Christian Hammond
* David Trowbridge
@@ -0,0 +1,11 @@

To install rbtools, simply run the following as root:

$ python install

Or to automatically download and install the latest version, you can run:

$ easy_install -U RBTools
@@ -0,0 +1,4 @@
include AUTHORS
include NEWS
include README
recursive-include contrib *
No changes.
@@ -0,0 +1,13 @@
About rbtools

rbtools is a collection of console utility scripts for use with Review Board.

This consists of the following officially supported tools:

* post-review - Create and update review requests based on changes in
a local tree.

There are also some user-contributed scripts and application plugins in the
contrib directory. See the associated README files for more information.
@@ -0,0 +1,2 @@
P4Win Tools for Review Board
>>post-review python "<Path of post-review goes here>" %C --p4-client $c --p4-port $p 1 0 1 0 0 1 0 0
@@ -0,0 +1,25 @@
About P4Tool

P4Tool.txt is an extension to P4win that adds support for invoking
post-review from the UI.


1) Make a copy of P4Tool.txt and modify it for your setup. Specifically,
you'll need to replace "<Path of post-review goes here>" with the path to
the post-review script on your system.

If using a compiled post-review.exe, place the path to this file and
remove "python" before the file path.

2) Import P4Tool.txt into P4win.


To post a change for review, right-click on the change and select
@@ -0,0 +1,272 @@
"""Bootstrap setuptools installation
If you want to use setuptools in your package's, just include this
file in the same directory with it, and add this to the top of your
from ez_setup import use_setuptools
If you want to require a specific version of setuptools, set a download
mirror, or use an alternate download directory, you can do so by supplying
the appropriate options to ``use_setuptools()``.
This file can also be run as a script to install or upgrade setuptools.
import sys
DEFAULT_URL = "" % sys.version[:3]

md5_data = {
'setuptools-0.6b1-py2.3.egg': '8822caf901250d848b996b7f25c6e6ca',
'setuptools-0.6b1-py2.4.egg': 'b79a8a403e4502fbb85ee3f1941735cb',
'setuptools-0.6b2-py2.3.egg': '5657759d8a6d8fc44070a9d07272d99b',
'setuptools-0.6b2-py2.4.egg': '4996a8d169d2be661fa32a6e52e4f82a',
'setuptools-0.6b3-py2.3.egg': 'bb31c0fc7399a63579975cad9f5a0618',
'setuptools-0.6b3-py2.4.egg': '38a8c6b3d6ecd22247f179f7da669fac',
'setuptools-0.6b4-py2.3.egg': '62045a24ed4e1ebc77fe039aa4e6f7e5',
'setuptools-0.6b4-py2.4.egg': '4cb2a185d228dacffb2d17f103b3b1c4',
'setuptools-0.6c1-py2.3.egg': 'b3f2b5539d65cb7f74ad79127f1a908c',
'setuptools-0.6c1-py2.4.egg': 'b45adeda0667d2d2ffe14009364f2a4b',
'setuptools-0.6c2-py2.3.egg': 'f0064bf6aa2b7d0f3ba0b43f20817c27',
'setuptools-0.6c2-py2.4.egg': '616192eec35f47e8ea16cd6a122b7277',
'setuptools-0.6c3-py2.3.egg': 'f181fa125dfe85a259c9cd6f1d7b78fa',
'setuptools-0.6c3-py2.4.egg': 'e0ed74682c998bfb73bf803a50e7b71e',
'setuptools-0.6c3-py2.5.egg': 'abef16fdd61955514841c7c6bd98965e',
'setuptools-0.6c4-py2.3.egg': 'b0b9131acab32022bfac7f44c5d7971f',
'setuptools-0.6c4-py2.4.egg': '2a1f9656d4fbf3c97bf946c0a124e6e2',
'setuptools-0.6c4-py2.5.egg': '8f5a052e32cdb9c72bcf4b5526f28afc',
'setuptools-0.6c5-py2.3.egg': 'ee9fd80965da04f2f3e6b3576e9d8167',
'setuptools-0.6c5-py2.4.egg': 'afe2adf1c01701ee841761f5bcd8aa64',
'setuptools-0.6c5-py2.5.egg': 'a8d3f61494ccaa8714dfed37bccd3d5d',
'setuptools-0.6c6-py2.3.egg': '35686b78116a668847237b69d549ec20',
'setuptools-0.6c6-py2.4.egg': '3c56af57be3225019260a644430065ab',
'setuptools-0.6c6-py2.5.egg': 'b2f8a7520709a5b34f80946de5f02f53',
'setuptools-0.6c7-py2.3.egg': '209fdf9adc3a615e5115b725658e13e2',
'setuptools-0.6c7-py2.4.egg': '5a8f954807d46a0fb67cf1f26c55a82e',
'setuptools-0.6c7-py2.5.egg': '45d2ad28f9750e7434111fde831e8372',
'setuptools-0.6c8-py2.3.egg': '50759d29b349db8cfd807ba8303f1902',
'setuptools-0.6c8-py2.4.egg': 'cba38d74f7d483c06e9daa6070cce6de',
'setuptools-0.6c8-py2.5.egg': '1721747ee329dc150590a58b3e1ac95b',

import sys, os

def _validate_md5(egg_name, data):
if egg_name in md5_data:
from md5 import md5
digest = md5(data).hexdigest()
if digest != md5_data[egg_name]:
print >>sys.stderr, (
"md5 validation of %s failed! (Possible download problem?)"
% egg_name
return data

def use_setuptools(
version=DEFAULT_VERSION, download_base=DEFAULT_URL, to_dir=os.curdir,
"""Automatically find/download setuptools and make it available on sys.path
`version` should be a valid setuptools version number that is available
as an egg for download under the `download_base` URL (which should end with
a '/'). `to_dir` is the directory where setuptools will be downloaded, if
it is not already available. If `download_delay` is specified, it should
be the number of seconds that will be paused before initiating a download,
should one be required. If an older version of setuptools is installed,
this routine will print a message to ``sys.stderr`` and raise SystemExit in
an attempt to abort the calling script.
was_imported = 'pkg_resources' in sys.modules or 'setuptools' in sys.modules
def do_download():
egg = download_setuptools(version, download_base, to_dir, download_delay)
sys.path.insert(0, egg)
import setuptools; setuptools.bootstrap_install_from = egg
import pkg_resources
except ImportError:
return do_download()
pkg_resources.require("setuptools>="+version); return
except pkg_resources.VersionConflict, e:
if was_imported:
print >>sys.stderr, (
"The required version of setuptools (>=%s) is not available, and\n"
"can't be installed while this script is running. Please install\n"
" a more recent version first, using 'easy_install -U setuptools'."
"\n\n(Currently using %r)"
) % (version, e.args[0])
del pkg_resources, sys.modules['pkg_resources'] # reload ok
return do_download()
except pkg_resources.DistributionNotFound:
return do_download()

def download_setuptools(
version=DEFAULT_VERSION, download_base=DEFAULT_URL, to_dir=os.curdir,
delay = 15
"""Download setuptools from a specified location and return its filename
`version` should be a valid setuptools version number that is available
as an egg for download under the `download_base` URL (which should end
with a '/'). `to_dir` is the directory where the egg will be downloaded.
`delay` is the number of seconds to pause before an actual download attempt.
import urllib2, shutil
egg_name = "setuptools-%s-py%s.egg" % (version,sys.version[:3])
url = download_base + egg_name
saveto = os.path.join(to_dir, egg_name)
src = dst = None
if not os.path.exists(saveto): # Avoid repeated downloads
from distutils import log
if delay:
This script requires setuptools version %s to run (even to display
help). I will attempt to download it for you (from
%s), but
you may need to enable firewall access for this script first.
I will start the download in %d seconds.
(Note: if this machine does not have network access, please obtain the file
and place it in this directory before rerunning this script.)
version, download_base, delay, url
); from time import sleep; sleep(delay)
log.warn("Downloading %s", url)
src = urllib2.urlopen(url)
# Read/write all in one block, so we don't create a corrupt file
# if the download is interrupted.
data = _validate_md5(egg_name,
dst = open(saveto,"wb"); dst.write(data)
if src: src.close()
if dst: dst.close()
return os.path.realpath(saveto)

def main(argv, version=DEFAULT_VERSION):
"""Install or upgrade setuptools and EasyInstall"""
import setuptools
except ImportError:
egg = None
egg = download_setuptools(version, delay=0)
from setuptools.command.easy_install import main
return main(list(argv)+[egg]) # we're done here
if egg and os.path.exists(egg):
if setuptools.__version__ == '0.0.1':
print >>sys.stderr, (
"You have an obsolete version of setuptools installed. Please\n"
"remove it from your system entirely before rerunning this script."

req = "setuptools>="+version
import pkg_resources
except pkg_resources.VersionConflict:
from setuptools.command.easy_install import main
except ImportError:
from easy_install import main
sys.exit(0) # try to force an exit
if argv:
from setuptools.command.easy_install import main
print "Setuptools version",version,"or greater has been installed."
print '(Run " -U setuptools" to reinstall or upgrade.)'

def update_md5(filenames):
"""Update our built-in md5 registry"""

import re
from md5 import md5

for name in filenames:
base = os.path.basename(name)
f = open(name,'rb')
md5_data[base] = md5(

data = [" %r: %r,\n" % it for it in md5_data.items()]
repl = "".join(data)

import inspect
srcfile = inspect.getsourcefile(sys.modules[__name__])
f = open(srcfile, 'rb'); src =; f.close()

match ="\nmd5_data = {\n([^}]+)}", src)
if not match:
print >>sys.stderr, "Internal error!"

src = src[:match.start(1)] + repl + src[match.end(1):]
f = open(srcfile,'w')

if __name__=='__main__':
if len(sys.argv)>2 and sys.argv[1]=='--md5update':

0 comments on commit f5ec35f

Please sign in to comment.
You can’t perform that action at this time.