Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a comment vulnerability allowing scripts to be loaded.
Due to the way that comments were loaded in, it was possible to terminate a script and inject a new one while loading the diff viewer. This isn't believed to have been a problem in the wild, but is certainly an important one to fix. We now ensure that the text is escaped at the point where it's being fed into the JavaScript. It's no longer possible to inject scripts. Thanks to Damian Johnson for the heads up and for the fix that this change is based on. This will be going into 1.5.7 and 1.6.3 releases.
- Loading branch information
Showing
3 changed files
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters