Commits on Sep 20, 2010
  1. @chipx86

    Release Review Board 1.5 RC 2.

    chipx86 committed Sep 20, 2010
  2. @chipx86

    Build Python 2.7 packages.

    chipx86 committed Sep 20, 2010
  3. @chipx86

    Fix a broken template variable in the Change Repository admin form.

    The "{{MEDIA_SERIAL}}" was written as "{{MEDIA_SERIAL}" (missing a "}").
    chipx86 committed Sep 20, 2010
Commits on Sep 19, 2010
  1. @chipx86
  2. @chipx86

    Update the name of the devserver script in the Getting Started guide.

    The old devserver was named Now it's
    chipx86 committed Sep 19, 2010
  3. @chipx86
Commits on Sep 18, 2010
  1. @chipx86

    Support PDF/PS output for the Admin Guide and User Manual.

    To generate PDF/PS manuals, we need to support generating Latex files,
    which had a number of problems. Our web API guides use nested tables and
    other markup that fails currently with the Latex writer. We also had
    a badly organized Table of Contents, which was fine for the HTML output but
    resulted in many duplicated pages for Latex.
    We now output two separate files, one for the Admin Guide and one for the
    User Manual. We don't output the API guide at all. We also use a real
    visible toctree instead of some toctrees reaching into sub-nodes with matching
    hidden toctrees, which was confusing Latex. The result is a difference in
    how the manual looks in HTML, but with a proper Table of Contents throughout.
    chipx86 committed Sep 18, 2010
Commits on Sep 15, 2010
  1. @chipx86

    Support gecos fields in the NIS backend.

    The NIS backend was failing pretty terribly on gecos fields, which allow
    additional information beyond a full name. We now make sure not to grab the
    rest of the fields when parsing out the full name.
    Fixes bug #1793
    chipx86 committed Sep 15, 2010
Commits on Sep 14, 2010
  1. @chipx86

    Require Djblets 0.6.4 or higher.

    chipx86 committed Sep 14, 2010
Commits on Sep 13, 2010
  1. @chipx86

    Fix some column spanning in the docs.

    The docs were having some columns span that didn't need to span.
    This is now fixed.
    chipx86 committed Sep 13, 2010
  2. @chipx86

    Improve usability of screenshot drag-and-drop.

    Screenshot drag-and-drop failed to properly scroll to the drop area, which on
    a brand new review request made it very hard to drop a screenshot. We now
    ensure that after animation, we scroll into view.
    This also prevents a JavaScript error when the drag events get a bit out of
    sync, which appears to be able to happen on Firefox when dragging into the
    container and then out via chrome rather than the page. We no longer assume
    that the dataTransfer object is non-null.
    chipx86 committed Sep 13, 2010
Commits on Sep 11, 2010
  1. @chipx86

    Fix Django 1.1 support with the CSRF token in the Password Recovery f…

    The Password Recovery form had to have the {% csrf_token %} tag added for
    Django 1.2. However, this broke Django 1.1. We now implement the tag's logic
    directly in the template, for now. In Review Board 1.6, we can require
    Django 1.2.
    chipx86 committed Sep 11, 2010
Commits on Sep 9, 2010
  1. @chipx86
  2. @chipx86
  3. @chipx86
  4. @chipx86
  5. @chipx86
  6. @chipx86

    Document that SQLite should really only be used for test installations.

    SQLite is not really built for large installs with concurrent usage, so
    point that out before people choose that route.
    chipx86 committed Sep 9, 2010
  7. @chipx86
  8. @chipx86
  9. @chipx86
  10. @chipx86
  11. @chipx86

    Reference a future version for the installation docs.

    As we're approaching the release of RB 1.5, it's time to update the
    "Installing In-Development Releases" docs to show an example for a *future*
    release, 1.6. We were showing 1.1, which isn't even a thing anymore.
    chipx86 committed Sep 9, 2010
  12. @chipx86
  13. @chipx86

    Document using an HTTP proxy during installation.

    A common problem people hit is being behind a proxy server and thinking they
    have to manually download everything. We now document how to use one with
    chipx86 committed Sep 9, 2010
Commits on Sep 7, 2010
  1. @chipx86

    Add a default profile for the "grumpy" user in the test fixtures.

    Now that the review request details page requires a profile, we need
    to have one for the "grumpy" user in order to pass Selenium tests. This
    adds the test and also updates the Selenium tests to ensure we have a
    profile before executing any pages.
    chipx86 committed Sep 7, 2010
  2. @chipx86

    Fix some instructions for the unit tests codebase docs.

    Some file paths were incorrect, causing the commands to fail. They should
    now be correct, along with some clarified docs on what to press after the
    syncdb command when asked if an administrator should be created.
    chipx86 committed Sep 7, 2010
  3. @chipx86

    Default to JSON results for the deprecated web API.

    The old web API by default would return JSON, rather than using HTTP Accept.
    To preserve compatibility, the @webapi_deprecated_in_1_5 decorator now
    forces an api_format value of "json" unless otherwise specified. This
    should keep existing clients working and prevent problems with the Selenium
    chipx86 committed Sep 7, 2010
  4. @chipx86

    Allow @valid_prefs_required to be used with @check_login_required.

    The review request details page requires a profile for authenticated users,
    so @valid_prefs_required was recently added for that view. However, this broke
    anonymous users, because @valid_prefs_required assumes that the user could only
    reach that point if they were logged in. This wasn't the case here, so now
    @valid_prefs_required checks to make sure the user is authenticated before
    performing the check. If the user is not authenticated, it assumes that the
    view will only check the profile for authenticated users, and passes control
    on to it.
    chipx86 committed Sep 7, 2010
Commits on Sep 5, 2010
  1. @chipx86

    Fixed some structural problems with hte new webapi documentation.

    The webapi documentation was missing some entries in the resource trees,
    and wasn't showing the list of resources on the main webapi page.
    We now properly have everything organized into toctrees, with the old
    resources/index.txt resource tree representation being moved out into its
    own file.
    chipx86 committed Sep 5, 2010
  2. @chipx86

    Fix broken links to documentation.

    The Windows installation guide had a broken link to PyCrypto.
    The webapi 1.0 screenshot comment documentation had a broken link to
    the screenshot documentation.
    chipx86 committed Sep 5, 2010
  3. @chipx86
  4. @chipx86

    Fix references in the webapi docs.

    The new version of Sphinx moved such things as xrefs into new "domains"
    (namespaces). The generator for webapi docs wasn't specifying the domain for
    "ref", so we ended up with blank references. We now use the "std" domain,
    which gives us our references back!
    chipx86 committed Sep 5, 2010
  5. @chipx86
  6. @chipx86

    Fix compatibility with Python 2.4.

    The new SHA1 validation exceptions used super() to call the parent class,
    but in Python 2.4, Exception is an old-style object and can't be used with
    super(). We now call the parent functions using the old ways.
    Fixes the build breakage.
    chipx86 committed Sep 5, 2010