-
-
Notifications
You must be signed in to change notification settings - Fork 24
feat(jq): add json convert json tfsec to rdjson #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jq): add json convert json tfsec to rdjson #26
Conversation
script.sh
Outdated
| TFSEC_PATH="${TEMP_PATH}/tfsec" | ||
| echo '::endgroup::' | ||
|
|
||
| echo "::group:: Installing jq ... https://stedolan.github.io/jq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need to install jq as every Available Environment has jq by default. https://github.com/actions/virtual-environments#available-environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, on entreprise we don't use runner with jq :/ i fix them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is fixed can you re-run pipeline ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, i see.
It's ok to include installing jq script when it's not available and it support windows/mac.
haya14busa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your contribution! 👍
|
Hi, @jplanckeel! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
|
🚀 [bumpr] Bumped! New version:v1.12.0 Changes:v1.11.0...v1.12.0 |
|
Hi, this change is breaking the action in cases where there are no Repro steps
I am not a Cheers! ETA: better to fix than to complain: #27 |
Hello,
exchange in this issue the links to the solutions do not come up, the idea would be to make a json converter from tfsec to rdjson with jq.
This PR install JQ and change tfsec ouput by json, parsing jq to translate to rdjson and change input format for reviewdog
Result :