Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: introduce logger and verbose mode #354

Open
wataash opened this issue Nov 8, 2019 · 2 comments
Open

Feature request: introduce logger and verbose mode #354

wataash opened this issue Nov 8, 2019 · 2 comments
Labels

Comments

@wataash
Copy link

@wataash wataash commented Nov 8, 2019

Hi, thank you for creating this great software!

I think reviewdog is too quiet about logging, making it hard to solve issues.

For instance, in -reporter=github-pr-check, CI_COMMIT must be complete (32 digits) sha1. If it's abbreviated to 7 digits (0123abc), reviewdog exits 0 with no output, but in actual an internal error occurs (described in google/go-github#1136) and the execution is failed. I had to debug reviewdog, and it took a few hours to understand what happened behind the scenes.

So I propose:

  • Introduce a logger for leveled-logigng (error, warning, info, debug) (such as logrus)
  • Add flag to control the log level (e.g. -q:error, default:warning, -v:info, -vv:debug)

Any opinion would be appreciated.

@haya14busa

This comment has been minimized.

Copy link
Member

@haya14busa haya14busa commented Dec 1, 2019

I like the idea to add verbose logging option.

@reviewdog/helpers Anyone want to design/implement this feature?

@okonomi

This comment has been minimized.

Copy link
Member

@okonomi okonomi commented Dec 8, 2019

While using reviewdog, Two types of problems occur.

  1. reviewdog's own operation problems

Problems related to CI environment information acquisition and git command execution.

  1. lint tool execution problems

lint tool is not working properly.
In many cases the lint tool fails to run in CI environment.

Information to help solve these problems:

  • Environment variables recognized by reviewdog
  • Command executed by reviewdog (argument of git command)
  • Executed lint tool and its result (stdout, stderr)

If I have this information, I will spend less time solving problems.

haya14busa added a commit that referenced this issue Jan 3, 2020
ref: #354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.