Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-github from v28 to v29 #428

Merged
merged 2 commits into from Jan 10, 2020
Merged

Update go-github from v28 to v29 #428

merged 2 commits into from Jan 10, 2020

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Jan 9, 2020

Fix #426

Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@mgrachev
Copy link
Member Author

@mgrachev mgrachev commented Jan 9, 2020

@haya14busa 👋 I got the error:

reviewdog: post failed for golint-github-check: failed to create check: json: cannot unmarshal string into Go struct field App.app.events of type github.Event

Could you explain where this error might be?

@mgrachev mgrachev requested a review from haya14busa Jan 9, 2020
@haya14busa
Copy link
Member

@haya14busa haya14busa commented Jan 9, 2020

fix google/go-github#1370

@Graham42 Graham42 mentioned this pull request Jan 9, 2020
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@haya14busa haya14busa left a comment

Thanks!

@haya14busa haya14busa merged commit 3231b28 into master Jan 10, 2020
28 checks passed
@mgrachev mgrachev deleted the update-go-github branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants