Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GitHub pull reviews api #63

Merged
merged 8 commits into from Dec 16, 2016
Merged

Conversation

haya14busa
Copy link
Member

ref: #58

@codecov-io
Copy link

codecov-io commented Dec 16, 2016

Current coverage is 79.36% (diff: 68.29%)

Merging #63 into master will decrease coverage by 0.41%

@@             master        #63   diff @@
==========================================
  Files            10         10          
  Lines           712        751    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            568        596    +28   
- Misses          100        106     +6   
- Partials         44         49     +5   

Powered by Codecov. Last update cc1a3c8...70b3298

@haya14busa haya14busa force-pushed the github-pull-reviews-api branch 2 times, most recently from 2f20e7f to e09fddb Compare December 16, 2016 04:56
mediaTypePullRequestReview = "application/vnd.github.black-cat-preview+json"
)

type Review struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type Review should have comment or be unexported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok because this struct is temporary one and replace it with go-github implementation later.

Comments []*ReviewComment `json:"comments,omitempty"`
}

type ReviewComment struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type ReviewComment should have comment or be unexported

@haya14busa haya14busa force-pushed the github-pull-reviews-api branch 2 times, most recently from eb355a6 to 70b3298 Compare December 16, 2016 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants