Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GitHub pull reviews api #63

Merged
merged 8 commits into from Dec 16, 2016
Merged

Introduce GitHub pull reviews api #63

merged 8 commits into from Dec 16, 2016

Conversation

@haya14busa
Copy link
Member

haya14busa commented Dec 16, 2016

ref: #58

@codecov-io
Copy link

codecov-io commented Dec 16, 2016

Current coverage is 79.36% (diff: 68.29%)

Merging #63 into master will decrease coverage by 0.41%

@@             master        #63   diff @@
==========================================
  Files            10         10          
  Lines           712        751    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            568        596    +28   
- Misses          100        106     +6   
- Partials         44         49     +5   

Powered by Codecov. Last update cc1a3c8...70b3298

@haya14busa haya14busa force-pushed the github-pull-reviews-api branch 2 times, most recently from 2f20e7f to e09fddb Dec 16, 2016
@haya14busa haya14busa force-pushed the github-pull-reviews-api branch from c8d0e12 to 7095c0c Dec 16, 2016
github.go Outdated
mediaTypePullRequestReview = "application/vnd.github.black-cat-preview+json"
)

type Review struct {

This comment has been minimized.

Copy link
@review-dog

review-dog Dec 16, 2016

Member

[golint] reported by reviewdog 🐶
exported type Review should have comment or be unexported

This comment has been minimized.

Copy link
@haya14busa

haya14busa Dec 25, 2016

Author Member

it's ok because this struct is temporary one and replace it with go-github implementation later.

github.go Outdated
Comments []*ReviewComment `json:"comments,omitempty"`
}

type ReviewComment struct {

This comment has been minimized.

Copy link
@review-dog

review-dog Dec 16, 2016

Member

[golint] reported by reviewdog 🐶
exported type ReviewComment should have comment or be unexported

@haya14busa haya14busa force-pushed the github-pull-reviews-api branch 2 times, most recently from eb355a6 to 70b3298 Dec 16, 2016
@haya14busa haya14busa force-pushed the github-pull-reviews-api branch from 70b3298 to dccb529 Dec 16, 2016
haya14busa added 2 commits Dec 16, 2016
@haya14busa haya14busa merged commit 3568427 into master Dec 16, 2016
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.258%
Details
@haya14busa haya14busa deleted the github-pull-reviews-api branch Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.