Skip to content

Commit

Permalink
Fix h1 report 986365
Browse files Browse the repository at this point in the history
  • Loading branch information
mbeccati committed Jan 19, 2021
1 parent 62a2a04 commit 00fdb8d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions RELEASE_NOTES.txt
Expand Up @@ -34,6 +34,9 @@ What's New in Revive Adserver 5.1.0
when displaying the website URL in the affiliate-preview.php tag
generation page.

* Fixed a reflected XSS vulnerability in afr.php that could still be achieved
on legacy browsers, bypassing a previous fix.


New Features
------------
Expand Down
2 changes: 1 addition & 1 deletion www/delivery_dev/afr.php
Expand Up @@ -77,7 +77,7 @@

$refresh = (int)$refresh;
// JS needs to be escaped twice: the setTimeout argument is evaluated at runtime
$jsDest = addcslashes(addcslashes($dest, "\0..\37\"\\"), "'\\");
$jsDest = addcslashes(addcslashes($dest, "\0..\37/\"\\"), "'\\");
$htmlDest = htmlspecialchars($dest, ENT_QUOTES);

// Try to use JS location.replace since browsers deal with this and history much better than meta-refresh
Expand Down

0 comments on commit 00fdb8d

Please sign in to comment.