Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix OX-6003 3rd Party Doubleclick and OpenX click tracking broken #71
Generating invocation tags with 3rd party click tracking enabled is broken in many ways:
The attached patch is meant to clean up the situation a bit by:
I'm not sure this fix is 100% ok. Will need some thorough testing.
Looks like %c for Doubleclick is still supported, but has been updated: https://support.google.com/dfp_premium/answer/1242718?hl=en (See the "click macro" section).
Interesting though that they now have:
But these seem to be the opposite of what the above suggests %c is - is %c simply single escaped? Is there now no option to get just the single escaped URL from Doubleclick? Or is %c "double escaped" and that is what is required?
So the changes all make sense to me. I think the think that is worth nothing though is that existing "OpenX zone in another OpenX as the 3rd party" setups are going to break. That is, at the moment:
If the OpenX instance that provided the zone tags is upgraded to Revive Adserver (once the above change is merged), then nothing would change - unless the zone tags were updated. In that case, then:
So, using new Revive Adserver tags in an old OpenX installation, if the changes were merged, would break all cases.
However, if the OpenX instance that is acting as the 3rd party server is upgraded to Revive Adserver (once the above change is merged), then things would change instantly:
Of course, if BOTH servers are updated, and the zone tags are all updated, then everything will be using escaped URLs, so everything will work.
The upshot of all of this is, that I believe that merging these changes:
So, realistically, while this change makes sense, it will break OpenX/Revive and Revive/OpenX tracking. Users of both installations would realistically need to upgrade, and all tags be re-issued, for the changes to be fully in place.
I don't think that is necessarily a bad thing, as it does sort out the mess, but we would have to be clear about it in the release notes - and a major version number is a good time to do it.