Skip to content

Conversation

@Xynnix
Copy link

@Xynnix Xynnix commented Oct 5, 2021

Not entirely sure if its needed to add this but I felt it would be helpful for those that would prefer using port 80 and a custom domain. ( If needed, Could state that nginx.conf needs edited where it says to replace if used with domain. (replacemewith.domain)

Copy link

@Mar0xy Mar0xy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice idea but I think this should be in a separate branch for people who still want to use their own server since otherwise they would need to go into the compose file and always remove the nginx part. I have also realized a small thing that I commented on.

proxy_set_header Connection "upgrade";
}
}
upstream ws-backend {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You defined an upstream yet the upstream does not get used for the websocket

@Xynnix
Copy link
Author

Xynnix commented Oct 6, 2021

I accidentally deleted the organization for this, i still have a copy of the changes on another org. so i will fix the comments and make a new branch on it for NGINX then. Sorry about being stupid and deleting the org either way.
AkiraGay/self-hosted has the updates and other changes. Should I make a PR From that?

@Xynnix
Copy link
Author

Xynnix commented Oct 6, 2021

I will close this since I doubt Github will allow merging from unknown repository. And make a second PR from the other one with the thing you noted removed since its unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants