Handle errory connection string

revolunet · Feb 8, 2012 · 7c20db7 · 7c20db7
1 parent 1f24314
commit 7c20db7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -100,6 +100,10 @@ dnode.prototype.connect = function () {
     }
 
     function attachDnode() {
+        if (!stream) {
+            self.emit('error', new Error('Could not create a stream with this information ' + JSON.stringify(params)))
+            return null
+        }
         client = createClient(self.proto, stream);
 
         client.end = function () {

diff --git a/test/error.js b/test/error.js
@@ -85,3 +85,15 @@ test('refused', function (t) {
         t.end();
     });
 });
+
+
+test('bad connection string', function(t) {
+    try {
+        var client = dnode.connect('garbage', function (remote, conn) {
+            assert.fail('should have been refused, very unlikely');
+        });
+    } catch (err) {
+        t.ok(/Could not create a stream/.test(err.message));
+        t.end();
+    }
+});