Declaring v1.0.0 #8

Closed
bclinkinbeard opened this Issue Mar 5, 2014 · 9 comments

Comments

Projects
None yet
5 participants
@bclinkinbeard
Contributor

bclinkinbeard commented Mar 5, 2014

So, this is kind of becoming a personal mission of mine, but what would you think about declaring a v1? The traditional criteria (stated if not practiced) has been if it's being used in production it's v1+. Coupled with npm's new ^ behavior, it would be great to be able to specify "rework-npm": "^1.0.0" and know any new, non-breaking hotness would be fetched on future installs.

Thoughts?

@ben-ng

This comment has been minimized.

Show comment Hide comment
@ben-ng

ben-ng Mar 6, 2014

+1

ben-ng commented Mar 6, 2014

+1

@Techwraith

This comment has been minimized.

Show comment Hide comment
@Techwraith

Techwraith Mar 6, 2014

👍

👍

@conradz

This comment has been minimized.

Show comment Hide comment
@conradz

conradz Mar 6, 2014

Contributor

Definitely should do this, but I think we need to wait for the css-parse to release v2.0.0, since the current version breaks with css-parse master.

Contributor

conradz commented Mar 6, 2014

Definitely should do this, but I think we need to wait for the css-parse to release v2.0.0, since the current version breaks with css-parse master.

@bclinkinbeard

This comment has been minimized.

Show comment Hide comment
@bclinkinbeard

bclinkinbeard Mar 6, 2014

Contributor

Ah OK, cool. Will that cause the API of rework-npm to change?

Contributor

bclinkinbeard commented Mar 6, 2014

Ah OK, cool. Will that cause the API of rework-npm to change?

@conradz

This comment has been minimized.

Show comment Hide comment
@conradz

conradz Mar 6, 2014

Contributor

Not sure yet, although it could be possible.

Contributor

conradz commented Mar 6, 2014

Not sure yet, although it could be possible.

@conradz

This comment has been minimized.

Show comment Hide comment
@conradz

conradz Mar 6, 2014

Contributor

Should also get #10 taken care of before a 1.0.

Contributor

conradz commented Mar 6, 2014

Should also get #10 taken care of before a 1.0.

@conradz

This comment has been minimized.

Show comment Hide comment
@conradz

conradz Jun 24, 2014

Contributor

OK, after moving to the reworkcss org and some breaking changes, I think this is ready to go.

Major changes:

  • Dropped the dir option, always use directory from position.source in the AST (see #10)
  • Search the alias option for aliased directories when importing (see #15)
  • Never apply the alias config for relative imports (e.g. @import "./file";)

Please test and provide feedback! /cc @bclinkinbeard @necolas

Contributor

conradz commented Jun 24, 2014

OK, after moving to the reworkcss org and some breaking changes, I think this is ready to go.

Major changes:

  • Dropped the dir option, always use directory from position.source in the AST (see #10)
  • Search the alias option for aliased directories when importing (see #15)
  • Never apply the alias config for relative imports (e.g. @import "./file";)

Please test and provide feedback! /cc @bclinkinbeard @necolas

@necolas

This comment has been minimized.

Show comment Hide comment
@necolas

necolas Jun 24, 2014

Contributor

Looks good to me! A couple of quick tests behaved as I expected.

Contributor

necolas commented Jun 24, 2014

Looks good to me! A couple of quick tests behaved as I expected.

@conradz

This comment has been minimized.

Show comment Hide comment
@conradz

conradz Jun 24, 2014

Contributor

Released v1.0.0!

Contributor

conradz commented Jun 24, 2014

Released v1.0.0!

@conradz conradz closed this Jun 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment