Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma in data attribute value causes bad CSS parse #164

Closed
meandmycode opened this issue Jun 3, 2014 · 2 comments
Closed

Comma in data attribute value causes bad CSS parse #164

meandmycode opened this issue Jun 3, 2014 · 2 comments

Comments

@meandmycode
Copy link

Given the following selector:

[data-value="this, that"] {

}

The resulting JSON is:

{
  rules: [
    {
      selectors: [ '[data-thing="', 'b"]' ]
    }
  ]
}

I believe this is probably related to trying to split the CSS selector text by comma, but isn't accounting for the presence of a comma within the attribute value.

@philipwalton
Copy link

I think this was fixed here, but I'm not sure if it's been merged into rework yet.

@necolas
Copy link
Contributor

necolas commented Jun 18, 2014

This is fixed in css. Will be in the next Rework release.

@necolas necolas closed this as completed Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants