Skip to content

Sample plugin doesn't support @media queries #35

Closed
ForbesLindesay opened this Issue Mar 4, 2013 · 3 comments

3 participants

@ForbesLindesay

The sample plugin doesn't support @media queries. It should probably be re-written to use visit.

@ForbesLindesay

Perhaps `visit should be moved to become part of the css-parser. It could be a method on the style-sheet.

@jonathanong

visit is already its own repo. i actually wanted all the rule created in css-parser to be an instanceof a Rule constructor, but tj thought it would make things too complicated. would be super nice to attach methods like visit to the prototype.

@tj
rework member
tj commented Oct 12, 2013

I've gone that route before, it's not bad or anything it just causes somewhat unnecessary bloat for what is otherwise a really simple project, and the jsonable output is nice, you can ship it around without "hydrating"

@jonathanong jonathanong added a commit that referenced this issue Dec 14, 2013
@jonathanong jonathanong readme: remove example plugin
as #35 says, it’s a bad example. also, the readme is quite long, and it
should be targeted towards consumers, not implementors. implementors
have plenty of plugins to learn from now.
582c6a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.